Re: [PATCH v3 10/11] trace: platform/x86/intel/ifs: Add trace point to track Intel IFS operations

Steven Rostedt
2022-04-20T23:38:48Z

On Tue, 19 Apr 2022 09:38:58 -0700
Tony Luck <tony.luck@intel.com> wrote:

> +TRACE_EVENT(ifs_status,
> +
> + TP_PROTO(union ifs_scan activate, union ifs_status status),

Really, you want to pass the structure in by value, so that we have two
copies? One to get to this function and then one to write to the ring
buffer?

-- Steve

> +
> + TP_ARGS(activate, status),
> +
> + TP_STRUCT__entry(
> + __field( u64, status )
> + __field( u8, start )
> + __field( u8, stop )
> + ),
> +
> + TP_fast_assign(
> + __entry->start = activate.start;
> + __entry->stop = activate.stop;
> + __entry->status = status.data;
> + ),
> +
> + TP_printk("start: %.2x, stop: %.2x, status: %llx",
> + __entry->start,
> + __entry->stop,
> + __entry->status)
> +);
> +
> +#endif /* _TRACE_IFS_H */