From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3038DC43461 for ; Tue, 6 Apr 2021 09:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4C20613C3 for ; Tue, 6 Apr 2021 09:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240604AbhDFJdp convert rfc822-to-8bit (ORCPT ); Tue, 6 Apr 2021 05:33:45 -0400 Received: from mga12.intel.com ([192.55.52.136]:14984 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236696AbhDFJdn (ORCPT ); Tue, 6 Apr 2021 05:33:43 -0400 IronPort-SDR: nAQjvgOFpT76wHt/4rwAtdtVM+I8aU2LkBV0j3hYQEzISCCMCT9ZyS0fQq/9qKYWSduU4RCbMx TwZF7dbCmFTw== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="172502141" X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="172502141" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 02:33:34 -0700 IronPort-SDR: yNx+NRizR5mkR8GcZPzlI8J7Pj0MjByUv03J9PMpLpN8+8z9CtxNE4aHX/zeWYKFAFUMA0T4x4 hC15JwVa90TA== X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="457817452" Received: from oowomilo-mobl2.ger.corp.intel.com (HELO localhost) ([10.249.33.55]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 02:33:03 -0700 From: Jani Nikula To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Thierry Reding , Lee Jones Cc: Jonathan Corbet , Michael Turquette , Stephen Boyd , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Support Opensource , Dmitry Torokhov , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Claudiu Beznea , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Heiko Stuebner , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Liam Girdwood , Mark Brown , Daniel Thompson , Jingoo Han , linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-fbdev@vger.kernel.org Subject: Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic In-Reply-To: <20210406073036.26857-1-u.kleine-koenig@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210406073036.26857-1-u.kleine-koenig@pengutronix.de> Date: Tue, 06 Apr 2021 12:32:58 +0300 Message-ID: <87tuojlpv9.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 06 Apr 2021, Uwe Kleine-König wrote: > Given that lowlevel drivers usually cannot implement exactly what a > consumer requests with pwm_apply_state() there is some rounding involved. > > pwm_get_state() traditionally returned the setting that was requested most > recently by the consumer (opposed to what was actually implemented in > hardware in reply to the last request). To make this semantic obvious > rename the function. > > Signed-off-by: Uwe Kleine-König > --- > drivers/gpu/drm/i915/display/intel_panel.c | 4 +-- Acked-by: Jani Nikula -- Jani Nikula, Intel Open Source Graphics Center