public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marius Bakke <marius@gnu.org>
To: ricky_wu@realtek.com
Cc: arnd@arndb.de, bhelgaas@google.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	puranjay12@gmail.com, rui_feng@realsil.com.cn,
	ulf.hansson@linaro.org, vailbhavgupta40@gamail.com
Subject: Sudden poweroffs when idle on ThinkPad x290s since v5.10-rc1 (bisected to 7c33e3c4c79a)
Date: Thu, 25 Mar 2021 20:33:16 +0100	[thread overview]
Message-ID: <87tuozm3k3.fsf@gnu.org> (raw)
In-Reply-To: 20200907100731.7722-1-ricky_wu@realtek.com

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

Hello,

After updating to the 5.10 kernel, my laptop will spontaneously poweroff
when idle after some time (between 30 minutes and three days).

I have bisected it down to a rtsx driver update in 7c33e3c4c79a:

commit 7c33e3c4c79ac5def79e7c773e38a7113eb14204
Author: Ricky Wu <ricky_wu@realtek.com>
Date:   Mon Sep 7 18:07:31 2020 +0800

    misc: rtsx: Add power saving functions and fix driving parameter
    
    v4:
    split power down flow and power saving function to two patch
    
    v5:
    fix up modified change under the --- line
    
    Add rts522a L1 sub-state support
    Save more power on rts5227 rts5249 rts525a rts5260
    Fix rts5260 driving parameter
    
    Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
    Link: https://lore.kernel.org/r/20200907100731.7722-1-ricky_wu@realtek.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

 drivers/misc/cardreader/rts5227.c  | 112 +++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5249.c  | 145 ++++++++++++++++++++++++++++++++++++-
 drivers/misc/cardreader/rts5260.c  |  28 +++----
 drivers/misc/cardreader/rtsx_pcr.h |  17 +++++
 4 files changed, 283 insertions(+), 19 deletions(-)

(See also <https://bugzilla.kernel.org/show_bug.cgi?id=211809>.)

I'm not sure whether this is a driver or hardware problem and am seeking
feedback on how to further debug the issue.

FWIW the problem does not seem to reproduce on an AMD ThinkPad T14 Gen 1
with the same RTS522A PCIe card reader (on stock Arch 5.10.16 kernel).

Thanks & happy hacking,
Marius

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

                 reply	other threads:[~2021-03-25 19:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuozm3k3.fsf@gnu.org \
    --to=marius@gnu.org \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=puranjay12@gmail.com \
    --cc=ricky_wu@realtek.com \
    --cc=rui_feng@realsil.com.cn \
    --cc=ulf.hansson@linaro.org \
    --cc=vailbhavgupta40@gamail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox