Re: [PATCH v3 4/5] KVM: X86: Drop KVM_APIC_SHORT_MASK and KVM_APIC_DEST_MASK

Peter Xu
2019-12-03T16:21:59Z

On Tue, Dec 03, 2019 at 02:19:16PM +0100, Vitaly Kuznetsov wrote:
> > @@ -4519,9 +4519,9 @@ static int avic_incomplete_ipi_interception(struct vcpu_svm *svm)
> > */
> > kvm_for_each_vcpu(i, vcpu, kvm) {
> > bool m = kvm_apic_match_dest(vcpu, apic,
> > - icrl & KVM_APIC_SHORT_MASK,
> > + icrl & APIC_SHORT_MASK,
> > GET_APIC_DEST_FIELD(icrh),
> > - icrl & KVM_APIC_DEST_MASK);
> > + icrl & APIC_DEST_MASK);
> >
> > if (m && !avic_vcpu_is_running(vcpu))
> > kvm_vcpu_wake_up(vcpu);
>
> Personal taste but I would've preserved KVM_ prefix. The patch itself
> looks correct, so

KVM apic uses apicdefs.h a lot, so I was trying to match them (APIC_*)
with it.

>
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Thanks for the reviews,

--
Peter Xu