From: Kalle Valo <kvalo@codeaurora.org>
To: Kai Heng Feng <kai.heng.feng@canonical.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi
Date: Wed, 03 Oct 2018 12:40:48 +0300 [thread overview]
Message-ID: <87tvm3id0f.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <265BAF93-4BFF-4850-92F7-80AC39496473@canonical.com> (Kai Heng Feng's message of "Wed, 3 Oct 2018 17:27:41 +0800")
Kai Heng Feng <kai.heng.feng@canonical.com> writes:
>> On Oct 3, 2018, at 5:10 PM, Kalle Valo <kvalo@codeaurora.org> wrote:
>>
>> Kai-Heng Feng <kai.heng.feng@canonical.com> writes:
>>
>>> To avoid the firmware loading race between Bluetooth and WiFi on Intel
>>> 8260, load firmware exclusively when BT_INTEL is enabled.
>>>
>>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>>
>> Still the commit log tells nothing about the actual problem which makes
>> review impossible.
>
> Sorry for that. The first two patches [1] only sends to linux-bluetooth and LMKL.
For a patchset like this you should CC linux-wireless for all patches,
otherwise people just get confused. And even more so as patch 3 seems to
depend on the other patches.
> I don’t know what really happened at hardware/firmware level, but
> making btusb and iwlwifi load firmware sequentially can workaround the
> issue.
We don't apply ugly workarounds without understanding the issue.
> Matt Chen may be able to explain this issue with more detail.
Then you need to work with Matt so that the issue is properly explained
in the commit log.
--
Kalle Valo
next prev parent reply other threads:[~2018-10-03 9:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 7:35 [RESEND] [PATCH 1/3] Bluetooth: btintel: Add firmware lock function Kai-Heng Feng
2018-10-03 7:35 ` [RESEND] [PATCH 2/3] Bluetooth: btusb: Load firmware exclusively for Intel BT Kai-Heng Feng
2018-10-03 7:35 ` [RESEND] [PATCH 3/3] iwlwifi: Load firmware exclusively for Intel WiFi Kai-Heng Feng
2018-10-03 9:10 ` Kalle Valo
2018-10-03 9:27 ` Kai Heng Feng
2018-10-03 9:40 ` Kalle Valo [this message]
2018-10-03 9:47 ` Kalle Valo
2018-10-03 9:50 ` Grumbach, Emmanuel
2018-10-03 9:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvm3id0f.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox