From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751859AbdKHJgg (ORCPT ); Wed, 8 Nov 2017 04:36:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40052 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbdKHJge (ORCPT ); Wed, 8 Nov 2017 04:36:34 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CF94349029 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=vkuznets@redhat.com From: Vitaly Kuznetsov To: Stephen Hemminger Cc: netdev , Stephen Hemminger , Eric Dumazet , Haiyang Zhang , linux-kernel@vger.kernel.org, devel@linuxdriverproject.org Subject: Re: [PATCH net-next v2 2/2] hv_netvsc: hide warnings about uninitialized/missing rndis device References: <20171102103531.5514-1-vkuznets@redhat.com> <20171102103531.5514-3-vkuznets@redhat.com> Date: Wed, 08 Nov 2017 10:36:30 +0100 In-Reply-To: (Stephen Hemminger's message of "Wed, 8 Nov 2017 07:17:18 +0100") Message-ID: <87tvy5m7s1.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 08 Nov 2017 09:36:34 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Hemminger writes: > On Nov 2, 2017 19:35, "Vitaly Kuznetsov" wrote: > > Hyper-V hosts are known to send RNDIS messages even after we halt the > device in rndis_filter_halt_device(). Remove user visible messages > as they are not really useful. > > Signed-off-by: Vitaly Kuznetsov > --- > drivers/net/hyperv/rndis_filter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c > index 0648eebda829..8b1242b8d8ef 100644 > --- a/drivers/net/hyperv/rndis_filter.c > +++ b/drivers/net/hyperv/rndis_filter.c > @@ -407,13 +407,13 @@ int rndis_filter_receive(struct net_device *ndev, > > /* Make sure the rndis device state is initialized */ > if (unlikely(!rndis_dev)) { > - netif_err(net_device_ctx, rx_err, ndev, > + netif_dbg(net_device_ctx, rx_err, ndev, > "got rndis message but no rndis device!\n"); > return NVSP_STAT_FAIL; > } > > if (unlikely(rndis_dev->state == RNDIS_DEV_UNINITIALIZED)) { > - netif_err(net_device_ctx, rx_err, ndev, > + netif_dbg(net_device_ctx, rx_err, ndev, > "got rndis message uninitialized\n"); > return NVSP_STAT_FAIL; > } > -- > 2.13.6 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel > > This should never happen since host removal should be setting device > down which disables NAPI. If this is not working correctly, that needs > to be fixed (rather than silencing the message). This happens in between we halt RNDIS device in rndis_filter_halt_device() and NAPI shutdown from netvsc_device_remove() while the window is still open. > > Don't shoot the messenger These messages are of no use for a random user: you change MTU on your device and see 'got rndis message uninitialized' - what are you supposed to do? I leave them at debugging level for us to actually debug. -- Vitaly