public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
	Rob Herring <robh@kernel.org>,
	devicetree@vger.kernel.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 04/20] ARM: dts: turris-omnia: Add generic compatible string for I2C EEPROM
Date: Thu, 08 Jun 2017 19:04:45 +0200	[thread overview]
Message-ID: <87tw3qpg0i.fsf@free-electrons.com> (raw)
In-Reply-To: <20170523133448.4794-5-javier@dowhile0.org> (Javier Martinez Canillas's message of "Tue, 23 May 2017 15:34:32 +0200")

Hi Javier,
 
 On mar., mai 23 2017, Javier Martinez Canillas <javier@dowhile0.org> wrote:

> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
>
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>

Applied on mvebu/dt

Thanks,

Gregory

>
> ---
>
> Changes in v5: None
> Changes in v4:
> - Only use the atmel manufacturer in the compatible string instead of
>   keeping the deprecated ones (Rob Herring).
>
> Changes in v3: None
> Changes in v2: None
>
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index 28eede180e4f..be16ce39fb3d 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -171,7 +171,7 @@
>  			/* leds device (in STM32F0) at address 0x2b */
>  
>  			eeprom@54 {
> -				compatible = "at,24c64";
> +				compatible = "atmel,24c64";
>  				reg = <0x54>;
>  
>  				/* The EEPROM contains data for bootloader.
> -- 
> 2.9.3
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2017-06-08 17:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170523133448.4794-1-javier@dowhile0.org>
2017-05-23 13:34 ` [PATCH v5 01/20] dt-bindings: i2c: eeprom: Document vendor to be used and deprecated ones Javier Martinez Canillas
2017-05-23 15:30   ` Rob Herring
2017-05-23 13:34 ` [PATCH v5 02/20] eeprom: at24: Add OF device ID table Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 03/20] ARM: dts: omap: Add generic compatible string for I2C EEPROM Javier Martinez Canillas
2017-05-26 15:51   ` Tony Lindgren
2017-05-23 13:34 ` [PATCH v5 04/20] ARM: dts: turris-omnia: " Javier Martinez Canillas
2017-06-08 17:04   ` Gregory CLEMENT [this message]
2017-05-23 13:34 ` [PATCH v5 05/20] ARM: dts: efm32: " Javier Martinez Canillas
2017-05-25 18:29   ` Uwe Kleine-König
2017-05-25 20:17     ` Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 06/20] ARM: dts: imx: " Javier Martinez Canillas
2017-05-25  7:32   ` Shawn Guo
2017-05-23 13:34 ` [PATCH v5 07/20] ARM: dts: keystone: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 08/20] ARM: dts: lpc18xx: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 09/20] ARM: dts: r7s72100: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 10/20] ARM: dts: koelsch: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 11/20] ARM: dts: socfpga: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 12/20] ARM: dts: uniphier: " Javier Martinez Canillas
2017-06-05  5:13   ` Masahiro Yamada
2017-06-06  9:04     ` Javier Martinez Canillas
2017-06-07  1:10       ` Masahiro Yamada
2017-06-07 12:42         ` Javier Martinez Canillas
2017-06-09 16:12           ` Masahiro Yamada
2017-05-23 13:34 ` [PATCH v5 13/20] ARM: dts: zynq: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 14/20] arm64: dts: ls1043a: " Javier Martinez Canillas
2017-05-25  7:33   ` Shawn Guo
2017-05-23 13:34 ` [PATCH v5 15/20] arm64: zynqmp: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 16/20] powerpc/5200: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 17/20] powerpc/fsl: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 18/20] powerpc/512x: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 19/20] powerpc/83xx: " Javier Martinez Canillas
2017-05-23 13:34 ` [PATCH v5 20/20] powerpc/44x: " Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw3qpg0i.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=javier@dowhile0.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox