From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751478AbdFHRE6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 8 Jun 2017 13:04:58 -0400
Received: from mail.free-electrons.com ([62.4.15.54]:38421 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750725AbdFHRE4 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Jun 2017 13:04:56 -0400
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: linux-kernel@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
        Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 04/20] ARM: dts: turris-omnia: Add generic compatible string for I2C EEPROM
References: <20170523133448.4794-1-javier@dowhile0.org>
        <20170523133448.4794-5-javier@dowhile0.org>
Date: Thu, 08 Jun 2017 19:04:45 +0200
In-Reply-To: <20170523133448.4794-5-javier@dowhile0.org> (Javier Martinez
        Canillas's message of "Tue, 23 May 2017 15:34:32 +0200")
Message-ID: <87tw3qpg0i.fsf@free-electrons.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Javier,
 
 On mar., mai 23 2017, Javier Martinez Canillas <javier@dowhile0.org> wrote:

> The at24 driver allows to register I2C EEPROM chips using different vendor
> and devices, but the I2C subsystem does not take the vendor into account
> when matching using the I2C table since it only has device entries.
>
> But when matching using an OF table, both the vendor and device has to be
> taken into account so the driver defines only a set of compatible strings
> using the "atmel" vendor as a generic fallback for compatible I2C devices.
>
> So add this generic fallback to the device node compatible string to make
> the device to match the driver using the OF device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>

Applied on mvebu/dt

Thanks,

Gregory

>
> ---
>
> Changes in v5: None
> Changes in v4:
> - Only use the atmel manufacturer in the compatible string instead of
>   keeping the deprecated ones (Rob Herring).
>
> Changes in v3: None
> Changes in v2: None
>
>  arch/arm/boot/dts/armada-385-turris-omnia.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index 28eede180e4f..be16ce39fb3d 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -171,7 +171,7 @@
>  			/* leds device (in STM32F0) at address 0x2b */
>  
>  			eeprom@54 {
> -				compatible = "at,24c64";
> +				compatible = "atmel,24c64";
>  				reg = <0x54>;
>  
>  				/* The EEPROM contains data for bootloader.
> -- 
> 2.9.3
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com