From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933028AbdELQku (ORCPT ); Fri, 12 May 2017 12:40:50 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:48114 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbdELQkt (ORCPT ); Fri, 12 May 2017 12:40:49 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Oleg Nesterov Cc: Kirill Tkhai , mhocko@suse.com, avagin@openvz.org, peterz@infradead.org, linux-kernel@vger.kernel.org, rppt@linux.vnet.ibm.com, luto@kernel.org, gorcunov@openvz.org, akpm@linux-foundation.org, mingo@kernel.org, serge@hallyn.com References: <149460544264.18650.5677597682925453388.stgit@localhost.localdomain> <20170512161705.GA18742@redhat.com> Date: Fri, 12 May 2017 11:34:24 -0500 In-Reply-To: <20170512161705.GA18742@redhat.com> (Oleg Nesterov's message of "Fri, 12 May 2017 18:17:06 +0200") Message-ID: <87tw4q11bj.fsf@xmission.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1d9DcU-0004X8-S0;;;mid=<87tw4q11bj.fsf@xmission.com>;;;hst=in02.mta.xmission.com;;;ip=97.121.81.159;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+FQuj+te2LjdBjgwVEAQ2hiGk74Lnp4tA= X-SA-Exim-Connect-IP: 97.121.81.159 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.5 XMGappySubj_01 Very gappy subject * 0.7 XMSubLong Long Subject * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_03 6+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Oleg Nesterov X-Spam-Relay-Country: X-Spam-Timing: total 264 ms - load_scoreonly_sql: 0.03 (0.0%), signal_user_changed: 2.4 (0.9%), b_tie_ro: 1.66 (0.6%), parse: 0.76 (0.3%), extract_message_metadata: 2.2 (0.8%), get_uri_detail_list: 0.70 (0.3%), tests_pri_-1000: 3.6 (1.4%), tests_pri_-950: 1.17 (0.4%), tests_pri_-900: 0.99 (0.4%), tests_pri_-400: 16 (6.2%), check_bayes: 15 (5.8%), b_tokenize: 5 (1.9%), b_tok_get_all: 4.9 (1.8%), b_comp_prob: 1.35 (0.5%), b_tok_touch_all: 2.4 (0.9%), b_finish: 0.57 (0.2%), tests_pri_0: 223 (84.5%), check_dkim_signature: 0.46 (0.2%), check_dkim_adsp: 3.6 (1.3%), tests_pri_500: 6 (2.1%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v2] pid_ns: Fix race between setns'ed fork() and zap_pid_ns_processes() X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oleg Nesterov writes: > On 05/12, Kirill Tkhai wrote: >> > --- a/kernel/fork.c >> +++ b/kernel/fork.c >> @@ -1845,11 +1845,13 @@ static __latent_entropy struct task_struct *copy_process( >> */ >> recalc_sigpending(); >> if (signal_pending(current)) { >> - spin_unlock(¤t->sighand->siglock); >> - write_unlock_irq(&tasklist_lock); >> retval = -ERESTARTNOINTR; >> goto bad_fork_cancel_cgroup; >> } >> + if (unlikely(!(ns_of_pid(pid)->nr_hashed & PIDNS_HASH_ADDING))) { >> + retval = -ENOMEM; >> + goto bad_fork_cancel_cgroup; >> + } >> >> if (likely(p->pid)) { >> ptrace_init_task(p, (clone_flags & CLONE_PTRACE) || trace); >> @@ -1907,6 +1909,8 @@ static __latent_entropy struct task_struct *copy_process( >> return p; >> >> bad_fork_cancel_cgroup: >> + spin_unlock(¤t->sighand->siglock); >> + write_unlock_irq(&tasklist_lock); >> cgroup_cancel_fork(p); > > Looks good to me. Oleg can I have a review or acked by? Then I will queue this up. Eric