From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933493AbdBPVAS convert rfc822-to-8bit (ORCPT ); Thu, 16 Feb 2017 16:00:18 -0500 Received: from mga05.intel.com ([192.55.52.43]:30834 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932975AbdBPVAQ (ORCPT ); Thu, 16 Feb 2017 16:00:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,169,1484035200"; d="scan'208";a="1128633813" From: Felipe Balbi To: Greg KH , Oliver Neukum Cc: "Gustavo A. R. Silva" , thomas@winischhofer.net, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] drivers: usb-misc: sisusbvga: remove dead code In-Reply-To: <20170216163919.GB30538@kroah.com> References: <20170208040134.GA4460@embeddedgus> <1487240929.22685.19.camel@suse.com> <20170216163919.GB30538@kroah.com> Date: Thu, 16 Feb 2017 22:59:47 +0200 Message-ID: <87tw7t4zss.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Greg KH writes: > On Thu, Feb 16, 2017 at 11:28:49AM +0100, Oliver Neukum wrote: >> Am Dienstag, den 07.02.2017, 22:01 -0600 schrieb Gustavo A. R. Silva: >> > The condition modex % 16 cannot be true when modex value is equal to >> > 640 >> > The condition du & 0xff cannot be true when du value is equal to >> > 0x1400 >> >  >> >> Sorry for speaking up so late, but this is not a good idea. >> We lose the knowledge how to do this correctly, if we want >> to change the resolution. > > Given the age of this driver, I doubt that will ever happen :) besides, the "knowledge" will always be in git history. -- balbi