From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbcJCPSV (ORCPT ); Mon, 3 Oct 2016 11:18:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46064 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbcJCPSN (ORCPT ); Mon, 3 Oct 2016 11:18:13 -0400 From: Vitaly Kuznetsov To: Konrad Rzeszutek Wilk Cc: xen-devel@lists.xenproject.org, Juergen Gross , Boris Ostrovsky , linux-kernel@vger.kernel.org, David Vrabel Subject: Re: [Xen-devel] [PATCH RFC] xen: make it possible to disable XEN_TMEM References: <1475503368-22878-1-git-send-email-vkuznets@redhat.com> <20161003141914.GH20896@char.us.oracle.com> Date: Mon, 03 Oct 2016 17:18:09 +0200 In-Reply-To: <20161003141914.GH20896@char.us.oracle.com> (Konrad Rzeszutek Wilk's message of "Mon, 3 Oct 2016 10:19:14 -0400") Message-ID: <87twct1mxa.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 03 Oct 2016 15:18:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Konrad Rzeszutek Wilk writes: > On Mon, Oct 03, 2016 at 04:02:48PM +0200, Vitaly Kuznetsov wrote: >> XEN_TMEM config option has no prompt and it is enabled as module by >> default if CLEANCACHE or FRONTSWAP options are set with no way to disable >> it. The only in-tree user of the tmem interface is xen-selfballoon which > > And if CONFIG_XEN=y . > Yes, of course) >> can itself be disabled so it makes sense to make it possible to disable > > During boot-time with arguments. I see, I rather meant we need a way to disable building the module, not just loading it. >> XEN_TMEM too. In theory, both these options could be unified under the >> XEN_SELFBALLOONING but other (out-of-tree) users of the tmem interface >> may exist and someone may want to keep them supported without enabling >> XEN_SELFBALLOONING. > > I think going the route of XEN_SELFBALLOONING may be better. Ok, if you say so) >> >> Signed-off-by: Vitaly Kuznetsov >> --- >> - I don't know much about tmem and its users thus RFC. >> --- >> drivers/xen/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig >> index f15bb3b7..0ea1df8 100644 >> --- a/drivers/xen/Kconfig >> +++ b/drivers/xen/Kconfig >> @@ -166,7 +166,7 @@ config SWIOTLB_XEN >> select SWIOTLB >> >> config XEN_TMEM >> - tristate >> + tristate "Transcendent Memory support for Xen" >> depends on !ARM && !ARM64 >> default m if (CLEANCACHE || FRONTSWAP) >> help >> -- >> 2.7.4 >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xen.org >> https://lists.xen.org/xen-devel -- Vitaly