From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756685AbcG0QI6 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 27 Jul 2016 12:08:58 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:33921 "EHLO
	mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754160AbcG0QI4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 27 Jul 2016 12:08:56 -0400
User-agent: mu4e 0.9.17; emacs 24.5.1
From: Mathieu OTHACEHE <m.othacehe@gmail.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Mathieu OTHACEHE <m.othacehe@gmail.com>, johan@kernel.org,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments
In-reply-to: <1469607216.2408.1.camel@suse.com>
Date: Wed, 27 Jul 2016 18:08:28 +0200
Message-ID: <87twfbnjwj.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

> this makes me think something is wrong with the data structure.
> We should have a be32 there, it seems to me.

You mean something like :

struct ti_write_data_bytes {
	u8	bAddrType;
	u8	bDataType;
	u8	bDataCounter;
	__be32	wBaseAddr;
	u8	bData[0];
} __packed;

and,

data->wBaseAddr = cpu_to_be32(addr) ?

Thanks,

Mathieu