From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932217AbcBAUlW (ORCPT ); Mon, 1 Feb 2016 15:41:22 -0500 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:31739 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872AbcBAUlU (ORCPT ); Mon, 1 Feb 2016 15:41:20 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 01 Feb 2016 21:41:19 +0100 X-ME-IP: 109.214.175.60 From: Robert Jarzmik To: Sergei Shtylyov Cc: Nicolas Pitre , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: smc91x: propagate irq return code References: <1454280377-25697-1-git-send-email-robert.jarzmik@free.fr> <56AF514D.6010608@cogentembedded.com> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 01 Feb 2016 21:41:15 +0100 In-Reply-To: <56AF514D.6010608@cogentembedded.com> (Sergei Shtylyov's message of "Mon, 1 Feb 2016 15:36:29 +0300") Message-ID: <87twls5fkk.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergei Shtylyov writes: > Hello. > > On 2/1/2016 1:46 AM, Robert Jarzmik wrote: > >> The smc91x driver doesn't honor the probe deferral mechanism when the >> interrupt source is not yet available, such as one provided by a gpio >> controller not probed. > What if 'ndev->irq' does equal 0? That's not possible AFAIR. There was a discussion where Linus had stated that the irq is a cookie, and a 0 value is "no interrupt", expcepting for the single case of a PC and its timer interrupt. As we're not in that case, and up to my understanding, platform_get_irq() cannot return a 0 value, only a strictly negative or positive one. And yet, that test now looks weird to me. I think I'll respin the patch with a "if (ndev->irq < 0) {" instead of the "if (ndev->irq <= 0) {". Cheers. -- Robert