Re: [PATCH 02/13] net: mvneta: enable IP checksum with jumbo frames for Armada 38x on Port0

Arnd Bergmann
2015-11-22T20:01:20Z

On Sunday 22 November 2015 08:53:48 Marcin Wojtas wrote:
> The Ethernet controller found in the Armada 38x SoC's family support
> TCP/IP checksumming with frame sizes larger than 1600 bytes, however
> only on port 0.
>
> This commit enables this feature by using 'marvell,armada-xp-neta' in
> 'ethernet@70000' node.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> Cc: <stable@vger.kernel.org> # v3.18+
> ---
> arch/arm/boot/dts/armada-38x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index c6a0e9d..b7868b2 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -494,7 +494,7 @@
> };
>
> eth0: ethernet@70000 {
> - compatible = "marvell,armada-370-neta";
> + compatible = "marvell,armada-xp-neta";
> reg = <0x70000 0x4000>;
> interrupts-extended = <&mpic 8>;
> clocks = <&gateclk 4>;
>

As it's clear that they are not 100% backwards compatible, please
add a SoC specific compatible string here as well, like

compatible = "marvell,armada-380-neta", "marvell,armada-xp-neta";

Maybe also leave the 370 string in place.

Arnd