Re: [PATCH 00/13] mvneta Buffer Management and enhancements

Gregory CLEMENT
2015-12-02T22:57:07Z

Hi Marcin,

On mer., déc. 02 2015, Marcin Wojtas <mw@semihalf.com> wrote:
>>>
>>>> 2. Change condition in mvebu_mbus_get_dram_win_info to:
>>>> if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size -1))
>>>
>>> I think it would be the best solution.
>>
>> So I applied the following patch:
>> --- a/drivers/bus/mvebu-mbus.c
>> +++ b/drivers/bus/mvebu-mbus.c
>> @@ -964,7 +964,7 @@ int mvebu_mbus_get_dram_win_info(phys_addr_t phyaddr, u8 *target, u8 *attr)
>> for (i = 0; i < dram->num_cs; i++) {
>> const struct mbus_dram_window *cs = dram->cs + i;
>>
>> - if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size)) {
>> + if (cs->base <= phyaddr && phyaddr <= (cs->base + cs->size - 1)) {
>> *target = dram->mbus_dram_target_id;
>> *attr = cs->mbus_attr;
>> return 0;
>>
>> I didn't get any errors during boot related to the BM. However I did not
>> manage to use an ethernet interface. The udhcpc never managed to get an
>> IP and if I set the IP manually I could not ping.
>>
>> But on Armada 388 GP I didn't have any issue.
>>
>> Do you have some idea about waht I could check?
>>
>
> I replaced 2GB with 8GB DIMM and after that, on the same kernel/board,
> I can't ping either. Very strange, but as I can reproduce the issue,
> don't debug it, I will.

Thanks to care about it!

Gregory

--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.