From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756780AbbI1HzJ (ORCPT ); Mon, 28 Sep 2015 03:55:09 -0400 Received: from smtp04.smtpout.orange.fr ([80.12.242.126]:24153 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752919AbbI1HzH (ORCPT ); Mon, 28 Sep 2015 03:55:07 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 28 Sep 2015 09:55:06 +0200 X-ME-IP: 109.222.127.209 From: Robert Jarzmik To: Brian Norris Cc: Ezequiel Garcia , David Woodhouse , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: nand: pxa3xx-nand: prevent DFI bus lockup on removal References: <1440961710-17347-1-git-send-email-robert.jarzmik@free.fr> <87a8s9exxg.fsf@belgarion.home> <20150928000515.GA34421@google.com> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 28 Sep 2015 09:50:00 +0200 In-Reply-To: <20150928000515.GA34421@google.com> (Brian Norris's message of "Sun, 27 Sep 2015 17:05:15 -0700") Message-ID: <87twqfdluf.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brian Norris writes: > On Sat, Sep 26, 2015 at 10:19:07PM +0200, Robert Jarzmik wrote: >> Robert Jarzmik writes: >> >> > After the conversion of pxa architecture to common clock framework, the >> > NAND clock can be disabled on driver exit. >> > >> > In this case, it happens that if the driver used the NAND and set the >> > DFI arbitration bit, the next access to a static memory controller area, >> > such as an ethernet card, will stall the system bus, and the core will >> > be stalled forever. >> > >> > This is especially true on pxa31x SoCs, where the NDCR was augmented >> > with a new bit to prevent this lockups by giving full ownership of the >> > DFI arbiter to the SMC, in change SCr#6. >> > >> > Fix this by clearing the DFI arbritration bit in driver exit. This >> > effectively prevents a lockup on zylonite when removing pxa3xx-nand >> > module, and using ethernet afterwards. >> > >> > Signed-off-by: Robert Jarzmik >> Hi Brian, >> >> Are you happy with this patch, and if so could you queue it please ? > > It looks OK to me, but it doesn't apply to the latest l2-mtd.git. Am I > missing something? I didn't try too hard to work out the conflict > myself. OK, I'll rebase it on your tree and resend a "PATCH v2 REBASED" version today. Cheers. -- Robert