From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753286AbbC3SjW (ORCPT ); Mon, 30 Mar 2015 14:39:22 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45583 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752932AbbC3SjU convert rfc822-to-8bit (ORCPT ); Mon, 30 Mar 2015 14:39:20 -0400 From: Kalle Valo To: Michael =?utf-8?Q?B=C3=BCsch?= Cc: Joe Perches , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 5/7] ssb: Use bool function return values of true/false not 1/0 References: <57da8293b865fb2d119e29073aec54323fc10000.1427736972.git.joe@perches.com> <20150330194901.5293fbe2@wiggum> Date: Mon, 30 Mar 2015 21:39:13 +0300 In-Reply-To: <20150330194901.5293fbe2@wiggum> ("Michael =?utf-8?Q?B=C3=BCs?= =?utf-8?Q?ch=22's?= message of "Mon, 30 Mar 2015 19:49:01 +0200") Message-ID: <87twx21ga6.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Büsch writes: > On Mon, 30 Mar 2015 10:43:21 -0700 > Joe Perches wrote: > >> Use the normal return values for bool functions >> >> Signed-off-by: Joe Perches >> --- >> drivers/ssb/driver_gige.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c >> index e973405..ebee6b0 100644 >> --- a/drivers/ssb/driver_gige.c >> +++ b/drivers/ssb/driver_gige.c >> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev, >> bool pdev_is_ssb_gige_core(struct pci_dev *pdev) >> { >> if (!pdev->resource[0].name) >> - return 0; >> + return false; >> return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0); >> } >> EXPORT_SYMBOL(pdev_is_ssb_gige_core); > > Looks good. > > Signed-off-by: Michael Buesch > > Kalle, can you take this one, please? Sure, I'll apply it in the next few days. -- Kalle Valo