checkpatch spell checking (was: Re: [Intel-gfx] [PATCH] drm/i915: Reudce CHV DPLL min vco frequency to 4.8 GHz)

checkpatch spell checking (was: Re: [Intel-gfx] [PATCH] drm/i915: Reudce CHV DPLL min vco frequency to 4.8 GHz)

[Jani Nikula]

On Wed, 04 Mar 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Wed, Mar 04, 2015 at 08:11:38PM +0530, Purushothaman, Vijay A wrote:
>> Minor nitpick: typo in patch title
>
> Dang. I already fixed a typo there before sending this out, but turns
> out I only managed to cchange it into a different typo :( Maybe I need
> to invest in a spell checker...

These days checkpatch.pl does some of this for you (see
scripts/spelling.txt). However your "reudce" isn't there, and, more
importantly, AFAICT checkpatch.pl does not look at the patch subject
anyway.

Joe, Andy, hint, hint. ;)


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center

Re: checkpatch spell checking (was: Re: [Intel-gfx] [PATCH] drm/i915: Reudce CHV DPLL min vco frequency to 4.8 GHz)

[Joe Perches]

On Thu, 2015-03-05 at 09:43 +0200, Jani Nikula wrote:
> On Wed, 04 Mar 2015, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> > On Wed, Mar 04, 2015 at 08:11:38PM +0530, Purushothaman, Vijay A wrote:
> >> Minor nitpick: typo in patch title
> >
> > Dang. I already fixed a typo there before sending this out, but turns
> > out I only managed to cchange it into a different typo :( Maybe I need
> > to invest in a spell checker...
> 
> These days checkpatch.pl does some of this for you (see
> scripts/spelling.txt). However your "reudce" isn't there, and, more
> importantly, AFAICT checkpatch.pl does not look at the patch subject
> anyway.
> 
> Joe, Andy, hint, hint. ;)

Patches happily accepted, (hint back..:)

(adding Kees Cook too)

[PATCH] checkpatch: Add spell checking of email subject line

[Joe Perches]

Only commit log and patch additions are checked for
typos and spelling errors currently.  Add a check
of the email subject line too.

Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/checkpatch.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 421bbb4..c061a63 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2303,7 +2303,8 @@ sub process {
 		}
 
 # Check for various typo / spelling mistakes
-		if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) {
+		if (defined($misspellings) &&
+		    ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
 			while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) {
 				my $typo = $1;
 				my $typo_fix = $spelling_fix{lc($typo)};

Re: [PATCH] checkpatch: Add spell checking of email subject line

[Jani Nikula]

On Thu, 05 Mar 2015, Joe Perches <joe@perches.com> wrote:
> Only commit log and patch additions are checked for
> typos and spelling errors currently.  Add a check
> of the email subject line too.
>
> Suggested-by: Jani Nikula <jani.nikula@linux.intel.com>
> Signed-off-by: Joe Perches <joe@perches.com>

Thanks Joe.

FWIW,

Tested-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  scripts/checkpatch.pl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 421bbb4..c061a63 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2303,7 +2303,8 @@ sub process {
>  		}
>  
>  # Check for various typo / spelling mistakes
> -		if (defined($misspellings) && ($in_commit_log || $line =~ /^\+/)) {
> +		if (defined($misspellings) &&
> +		    ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) {
>  			while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:$|[^a-z@])/gi) {
>  				my $typo = $1;
>  				my $typo_fix = $spelling_fix{lc($typo)};
>
>

-- 
Jani Nikula, Intel Open Source Technology Center

[PATCH] checkpatch: spell check reudce

[Jani Nikula]

References: http://mid.gmane.org/1424977312-24902-1-git-send-email-ville.syrjala@linux.intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 scripts/spelling.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/spelling.txt b/scripts/spelling.txt
index fc7fd52b5e03..bb8e4d0a1911 100644
--- a/scripts/spelling.txt
+++ b/scripts/spelling.txt
@@ -825,6 +825,7 @@ retreived||retrieved
 retreive||retrieve
 retrive||retrieve
 retuned||returned
+reudce||reduce
 reuest||request
 reuqest||request
 reutnred||returned
-- 
2.1.4