From: "Bjørn Mork" <bjorn@mork.no>
To: Hayes Wang <hayeswang@realtek.com>
Cc: <netdev@vger.kernel.org>, <nic_swsd@realtek.com>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] r8152: add CONFIG_RTL8152_EARLY_AGG_SUPER
Date: Wed, 12 Mar 2014 14:40:17 +0100 [thread overview]
Message-ID: <87txb3lem6.fsf@nemi.mork.no> (raw)
In-Reply-To: <1394628023-12713-1-git-send-email-hayeswang@realtek.com> (Hayes Wang's message of "Wed, 12 Mar 2014 20:39:58 +0800")
Hayes Wang <hayeswang@realtek.com> writes:
> + config RTL8152_EARLY_AGG_SUPER
> + hex "rx early agg parameter for super speed"
> + default 0x0e832981
> + help
> + This is the rx early agg parameter for USB super speed.
> +
> + endmenu
How do I as an end user know how to adjust this magic(?) value? Having
a config setting like this without further documentation seems
completely pointless. Anyone with enough knowledge about the driver and
devices will be perfectly capable of editing the driver source anyway.
Bjørn
next prev parent reply other threads:[~2014-03-12 13:47 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 12:00 [PATCH net-next 00/12] r8152: new features Hayes Wang
2014-03-04 12:00 ` [PATCH net-next 01/12] r8152: deal with the empty line and space Hayes Wang
2014-03-04 12:00 ` [PATCH net-next 02/12] r8152: replace tp->netdev with netdev Hayes Wang
2014-03-04 12:00 ` [PATCH net-next 03/12] r8152: remove rtl8152_get_stats Hayes Wang
2014-03-04 12:00 ` [PATCH net-next 04/12] r8152: replace spin_lock_irqsave and spin_unlock_irqrestore Hayes Wang
2014-03-04 12:00 ` [PATCH net-next 05/12] r8152: check tx agg list before spin lock Hayes Wang
2014-03-04 12:00 ` [PATCH net-next 06/12] r8152: up the priority of the transmission Hayes Wang
2014-03-04 12:00 ` [PATCH net-next 07/12] r8152: support rx checksum Hayes Wang
2014-03-04 21:32 ` David Miller
2014-03-04 12:01 ` [PATCH net-next 08/12] r8152: support TSO Hayes Wang
2014-03-04 12:11 ` David Laight
2014-03-04 13:11 ` hayeswang
2014-03-04 14:35 ` David Laight
2014-03-04 15:02 ` Eric Dumazet
2014-03-04 15:14 ` David Laight
2014-03-04 16:11 ` Eric Dumazet
2014-03-04 16:52 ` Eric Dumazet
2014-03-04 12:01 ` [PATCH net-next 09/12] r8152: support IPv6 Hayes Wang
2014-03-04 16:58 ` Eric Dumazet
2014-03-04 12:01 ` [PATCH net-next 10/12] r8152: reduce the numbers of the bulks Hayes Wang
2014-03-04 12:01 ` [PATCH net-next 11/12] r8152: add additional parameter for non x86 platform Hayes Wang
2014-03-04 12:01 ` [PATCH net-next 12/12] r8152: modify the tx timeout funcfion Hayes Wang
2014-03-25 20:12 ` Grant Grundler
2014-03-26 9:54 ` hayeswang
2014-03-05 6:49 ` [PATCH net-next v2 00/13] r8152: new features Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 01/13] r8152: deal with the empty line and space Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 02/13] r8152: replace tp->netdev with netdev Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 03/13] r8152: remove rtl8152_get_stats Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 04/13] r8152: replace spin_lock_irqsave and spin_unlock_irqrestore Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 05/13] r8152: check tx agg list before spin lock Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 06/13] r8152: up the priority of the transmission Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 07/13] r8152: calculate the dropped packets for rx Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 08/13] r8152: support rx checksum Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 09/13] r8152: support TSO Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 10/13] r8152: support IPv6 Hayes Wang
2014-03-09 19:47 ` Ben Hutchings
2014-03-09 22:56 ` David Miller
2014-03-05 6:49 ` [PATCH net-next v2 11/13] r8152: reduce the numbers of the bulks Hayes Wang
2014-03-05 6:49 ` [PATCH net-next v2 12/13] r8152: add additional parameter for non x86 platform Hayes Wang
2014-03-06 5:05 ` David Miller
2014-03-05 6:49 ` [PATCH net-next v2 13/13] r8152: modify the tx timeout funcfion Hayes Wang
2014-03-06 7:07 ` [PATCH net-next 0/3] r8152: cleanups Hayes Wang
2014-03-06 7:07 ` [PATCH net-next 1/3] r8152: deal with the empty line and space Hayes Wang
2014-03-06 7:07 ` [PATCH net-next 2/3] r8152: replace tp->netdev with netdev Hayes Wang
2014-03-06 7:07 ` [PATCH net-next 3/3] r8152: remove rtl8152_get_stats Hayes Wang
2014-03-06 18:17 ` [PATCH net-next 0/3] r8152: cleanups David Miller
2014-03-07 3:04 ` [PATCH net-next 0/7] r8152: tx/rx improvement Hayes Wang
2014-03-07 3:04 ` [PATCH net-next 1/7] r8152: replace spin_lock_irqsave and spin_unlock_irqrestore Hayes Wang
2014-03-07 3:04 ` [PATCH net-next 2/7] r8152: check tx agg list before spin lock Hayes Wang
2014-03-07 3:04 ` [PATCH net-next 3/7] r8152: up the priority of the transmission Hayes Wang
2014-03-07 3:04 ` [PATCH net-next 4/7] r8152: calculate the dropped packets for rx Hayes Wang
2014-03-07 3:04 ` [PATCH net-next 5/7] r8152: support rx checksum Hayes Wang
2014-03-07 3:04 ` [PATCH net-next 6/7] r8152: support TSO Hayes Wang
2014-03-07 3:04 ` [PATCH net-next 7/7] r8152: support IPv6 Hayes Wang
2014-03-07 21:27 ` [PATCH net-next 0/7] r8152: tx/rx improvement David Miller
2014-03-10 3:45 ` hayeswang
2014-03-10 6:22 ` [PATCH net-next] r8152: add skb_cow_head Hayes Wang
2014-03-10 20:31 ` David Miller
2014-03-11 2:20 ` [PATCH net-next v2] " Hayes Wang
2014-03-11 2:25 ` David Miller
2014-03-12 12:39 ` [PATCH net-next 0/2] parameter modification Hayes Wang
2014-03-12 12:39 ` [PATCH net-next 1/2] r8152: add CONFIG_RTL8152_EARLY_AGG_SUPER Hayes Wang
2014-03-12 13:40 ` Bjørn Mork [this message]
2014-03-12 12:39 ` [PATCH net-next 2/2] r8152: reduce the numbers of the bulks Hayes Wang
2014-03-13 3:34 ` [PATCH net-next v2 0/2] parameter modification Hayes Wang
2014-03-13 3:34 ` [PATCH net-next v2 1/2] r8152: add RTL8152_EARLY_AGG_TIMEOUT_SUPER Hayes Wang
2014-03-13 9:28 ` David Laight
2014-03-13 3:34 ` [PATCH net-next v2 2/2] r8152: reduce the numbers of the bulks Hayes Wang
2014-03-13 12:05 ` [PATCH net-next v3 0/2] parameter modification Hayes Wang
2014-03-13 12:05 ` [PATCH net-next v3 1/2] r8152: add RTL8152_EARLY_AGG_TIMEOUT_SUPER Hayes Wang
2014-03-13 13:12 ` David Laight
2014-03-13 17:22 ` David Miller
2014-03-14 2:37 ` [PATCH net-next v3 1/2] r8152: addRTL8152_EARLY_AGG_TIMEOUT_SUPER hayeswang
2014-03-14 4:07 ` David Miller
2014-03-14 7:24 ` [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER hayeswang
2014-03-14 18:43 ` David Miller
2014-03-17 6:01 ` [PATCH net-next v3 1/2]r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER hayeswang
2014-03-14 23:42 ` [PATCH net-next v3 1/2] r8152:addRTL8152_EARLY_AGG_TIMEOUT_SUPER Francois Romieu
2014-03-17 6:03 ` hayeswang
2014-03-13 12:05 ` [PATCH net-next v3 2/2] r8152: reduce the numbers of the bulks Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txb3lem6.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=hayeswang@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox