From: Rusty Russell <rusty@rustcorp.com.au>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/module: Replace include of tracepoint.h with jump_label.h in module.h
Date: Fri, 07 Mar 2014 14:02:56 +1030 [thread overview]
Message-ID: <87txbay97b.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20140306103414.15ab227a@gandalf.local.home>
Steven Rostedt <rostedt@goodmis.org> writes:
> Rusty,
>
> Can you give an Acked-by for this patch so that I can include it in my
> 3.15 queue. I have some patches there that need to be added before this
> change can go in.
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks,
Rusty.
>
> Thanks,
>
> -- Steve
>
>
> ----
> There's nothing in the module.h header that requires tracepoint.h to be
> included, and there may be cases that tracepoint.h may need to include
> module.h, which will cause recursive header issues.
>
> But module.h requires seeing HAVE_JUMP_LABEL which is set in
> jump_label.h which it just coincidentally gets from tracepoint.h.
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> include/linux/module.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index eaf60ff..5a50539 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -15,7 +15,7 @@
> #include <linux/stringify.h>
> #include <linux/kobject.h>
> #include <linux/moduleparam.h>
> -#include <linux/tracepoint.h>
> +#include <linux/jump_label.h>
> #include <linux/export.h>
>
> #include <linux/percpu.h>
> --
> 1.8.5.3
next prev parent reply other threads:[~2014-03-07 3:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 15:34 [PATCH] tracing/module: Replace include of tracepoint.h with jump_label.h in module.h Steven Rostedt
2014-03-07 3:32 ` Rusty Russell [this message]
2014-03-07 13:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txbay97b.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox