[PATCH] tracing/module: Replace include of tracepoint.h with jump_label.h in module.h

[PATCH] tracing/module: Replace include of tracepoint.h with jump_label.h in module.h

[Steven Rostedt]

Rusty,

Can you give an Acked-by for this patch so that I can include it in my
3.15 queue. I have some patches there that need to be added before this
change can go in.

Thanks,

-- Steve


----
There's nothing in the module.h header that requires tracepoint.h to be
included, and there may be cases that tracepoint.h may need to include
module.h, which will cause recursive header issues.

But module.h requires seeing HAVE_JUMP_LABEL which is set in
jump_label.h which it just coincidentally gets from tracepoint.h.

Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 include/linux/module.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/module.h b/include/linux/module.h
index eaf60ff..5a50539 100644
--- a/include/linux/module.h
+++ b/include/linux/module.h
@@ -15,7 +15,7 @@
 #include <linux/stringify.h>
 #include <linux/kobject.h>
 #include <linux/moduleparam.h>
-#include <linux/tracepoint.h>
+#include <linux/jump_label.h>
 #include <linux/export.h>
 
 #include <linux/percpu.h>
-- 
1.8.5.3

Re: [PATCH] tracing/module: Replace include of tracepoint.h with jump_label.h in module.h

[Rusty Russell]

Steven Rostedt <rostedt@goodmis.org> writes:
> Rusty,
>
> Can you give an Acked-by for this patch so that I can include it in my
> 3.15 queue. I have some patches there that need to be added before this
> change can go in.

Acked-by: Rusty Russell <rusty@rustcorp.com.au>

Thanks,
Rusty.

>
> Thanks,
>
> -- Steve
>
>
> ----
> There's nothing in the module.h header that requires tracepoint.h to be
> included, and there may be cases that tracepoint.h may need to include
> module.h, which will cause recursive header issues.
>
> But module.h requires seeing HAVE_JUMP_LABEL which is set in
> jump_label.h which it just coincidentally gets from tracepoint.h.
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
>  include/linux/module.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index eaf60ff..5a50539 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -15,7 +15,7 @@
>  #include <linux/stringify.h>
>  #include <linux/kobject.h>
>  #include <linux/moduleparam.h>
> -#include <linux/tracepoint.h>
> +#include <linux/jump_label.h>
>  #include <linux/export.h>
>  
>  #include <linux/percpu.h>
> -- 
> 1.8.5.3

Re: [PATCH] tracing/module: Replace include of tracepoint.h with jump_label.h in module.h

[Steven Rostedt]

On Fri, 07 Mar 2014 14:02:56 +1030
Rusty Russell <rusty@rustcorp.com.au> wrote:

> Steven Rostedt <rostedt@goodmis.org> writes:
> > Rusty,
> >
> > Can you give an Acked-by for this patch so that I can include it in my
> > 3.15 queue. I have some patches there that need to be added before this
> > change can go in.
> 
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
> 

Thank you!

-- Steve