From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Amit Sahrawat <a.sahrawat@samsung.com>
Subject: Re: [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size
Date: Tue, 04 Feb 2014 23:52:21 +0900 [thread overview]
Message-ID: <87txcfudzu.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <87y51rue2a.fsf@devron.myhome.or.jp> (OGAWA Hirofumi's message of "Tue, 04 Feb 2014 23:50:53 +0900")
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>>> Don't we need to update ->i_disksize after cont_write_begin()?
>> We don't need to update i_disksize after cont_write_begin.
>> It is taken care by the fat_get_block after the allocation.
>> For all write paths we align the mmu_private and i_disksize from
>> fat_fill_inode and fat_get_block.
>
> fat_fill_inode() just set i_disksize to i_size. So, it is not aligned by
> cluster size or block size.
>
> E.g. ->mmu_private = 500. Then, cont_write_begin() can set ->mmu_private
> to 512 on some case. In this case, fat_get_block() will not be called,
> because no new allocation.
>
> If this is true, it would be possible to have ->mmu_private == 512 and
> ->i_disksize == 500.
>
> I'm missing something?
BTW, even if above was right, I'm not checking whether updating
->i_disksize after cont_write_begin() is right fix or not.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2014-02-04 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 6:30 [PATCH v3 1/6] fat: add i_disksize to represent uninitialized size Namjae Jeon
2014-02-03 4:20 ` OGAWA Hirofumi
2014-02-04 10:20 ` Namjae Jeon
2014-02-04 14:50 ` OGAWA Hirofumi
2014-02-04 14:52 ` OGAWA Hirofumi [this message]
2014-02-06 6:41 ` Namjae Jeon
2014-02-06 12:18 ` OGAWA Hirofumi
2014-02-07 4:23 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txcfudzu.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox