public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Josh Boyer <jwboyer@fedoraproject.org>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>
Subject: Re: [RFC] Packaging libtraceevent.so
Date: Tue, 03 Dec 2013 15:02:18 +0900	[thread overview]
Message-ID: <87txeqmpzp.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20131202140322.4ad6a151@gandalf.local.home> (Steven Rostedt's message of "Mon, 2 Dec 2013 14:03:22 -0500")

Hi Steve,

(also add Jiri to CC list, hi!)

On Mon, 2 Dec 2013 14:03:22 -0500, Steven Rostedt wrote:
> Hi all!
>
> The question has recently come up in Fedora about packaging the
> libtraceevent.so library. Currently there's 4 users of it:
>
>  1) perf
>  2) trace-cmd
>  3) powertop
>  4) rasdaemon
>
> But each have their own copy of the code.
>
> Both perf and trace-cmd are the major developers of the package, and I
> would recommend that they continue using the *.a version, but for those
> tools that are simple users of the library, it would probably make
> sense to have them use libtraceevent.so and remove their copies from
> the code (powertop and rasdaemon).
>
> The question that I'm posing here is, what currently needs to be done
> to have this happen?

I think the most important thing is error handling.  The filter parser
code still has some calls to die().  It should be converted to return
error and appropriate error messages IMHO.  But I didn't check it'd
affect to the end-user APIs though.

And it needs to add plugin APIs before the public release.

>
> Is the API stable enough for a release?

Well, afaics the plugin unregister API should pass pevent as an argument
so that it can unregister individual event/function handlers in it.

Other than that I think it's pretty stable. :)

Thanks,
Namhyung

>
> We probably should have a dot versioning with the .so (ie.
> libtraceevent.so.1)
>
> So what are people's thoughts on this topic?
>
> -- Steve

  parent reply	other threads:[~2013-12-03  6:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-02 19:03 [RFC] Packaging libtraceevent.so Steven Rostedt
2013-12-02 19:04 ` Arjan van de Ven
2013-12-03  6:02 ` Namhyung Kim [this message]
2013-12-03 13:56   ` Josh Boyer
2013-12-03 15:23     ` Steven Rostedt
2013-12-03 15:22   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txeqmpzp.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=arjan@linux.intel.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=mingo@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox