Re: [PATCHSET 00/12] tracing/uprobes: Add support for more fetch methods

Namhyung Kim
2013-07-04T07:20:20Z

Hi Masami,

On Thu, 04 Jul 2013 15:51:52 +0900, Masami Hiramatsu wrote:
> (2013/07/03 21:35), Namhyung Kim wrote:
>> Hello,
>>
>> This patchset implements memory (address), stack[N], deference,
>> bitfield and retval (it needs uretprobe tho) fetch methods for
>> uprobes. It's based on the previous work [1] done by Hyeoncheol Lee.
>>
>> Now kprobes and uprobes have their own fetch_type_tables and, in turn,
>> memory and stack access methods. Other fetch methods are shared.
>>
>> For the dereference method, I added a new argument to fetch functions.
>> It's because for uprobes it needs to know whether the given address is
>> a file offset or a virtual address in an user process. For instance,
>> in case of fetching from a memory directly (like @offset) it should
>> convert the address (offset) to a virtual address of the process, but
>> if it's a dereferencing, the given address already has the virtual
>> address.
>
> Thanks Namhyung,
> I agree that uprobe requires a special (file-relative) dereference
> code. I'll look into the basic implementation after fixing current
> dynamic-event related bugs. :)
> (I see, this one should be updated to the latest tree, after
> merge window is closed)

Yes, I'm catching up the changes. I'll resend v2 after -rc1 released.

Thanks,
Namhyung