From: Chris Ball <cjb@laptop.org>
To: Roger Tseng <rogerable@realtek.com>
Cc: <sameo@linux.intel.com>, <devel@linuxdriverproject.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<gregkh@linuxfoundation.org>, <wei_wang@realsil.com.cn>
Subject: Re: [PATCH 1/3] MMC: rtsx: remove driving adjustment
Date: Mon, 11 Feb 2013 12:53:13 -0500 [thread overview]
Message-ID: <87txpipwja.fsf@octavius.laptop.org> (raw)
In-Reply-To: <1359963959-2305-2-git-send-email-rogerable@realtek.com> (Roger Tseng's message of "Mon, 4 Feb 2013 15:45:57 +0800")
Hi,
On Mon, Feb 04 2013, Roger Tseng wrote:
> Several new models of readers use different way to select driving
> capability(a necessary adjustment along with voltage change). Removing this
> from device-independent rtsx_pci_sdmmc module. It will be implemented in
> device-depend calls encapsulated by rtsx_pci_switch_output_voltage().
>
> Signed-off-by: Roger Tseng <rogerable@realtek.com>
> Reviewed-by: Wei WANG <wei_wang@realsil.com.cn>
> ---
> drivers/mmc/host/rtsx_pci_sdmmc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c b/drivers/mmc/host/rtsx_pci_sdmmc.c
> index f74b5ad..f93f100 100644
> --- a/drivers/mmc/host/rtsx_pci_sdmmc.c
> +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c
> @@ -1083,11 +1083,6 @@ static int sdmmc_switch_voltage(struct mmc_host *mmc, struct mmc_ios *ios)
> voltage = OUTPUT_1V8;
>
> if (voltage == OUTPUT_1V8) {
> - err = rtsx_pci_write_register(pcr,
> - SD30_DRIVE_SEL, 0x07, DRIVER_TYPE_B);
> - if (err < 0)
> - goto out;
> -
> err = sd_wait_voltage_stable_1(host);
> if (err < 0)
> goto out;
Thanks, I've pushed 1/3 to mmc-next for 3.9 now.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
next prev parent reply other threads:[~2013-02-11 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 7:45 [PATCH 0/3] rtsx: patchset for supporting new model RTS5227 Roger Tseng
2013-02-04 7:45 ` [PATCH 1/3] MMC: rtsx: remove driving adjustment Roger Tseng
2013-02-04 8:47 ` Dan Carpenter
2013-02-05 2:51 ` Roger Tseng
2013-02-05 8:30 ` Dan Carpenter
2013-02-11 17:53 ` Chris Ball [this message]
2013-02-04 7:45 ` [PATCH 2/3] mfd: rtsx: implement driving adjustment to device-dependent callbacks Roger Tseng
2013-02-04 11:56 ` Samuel Ortiz
2013-02-04 7:45 ` [PATCH 3/3] mfd: rtsx: support RTS5227 Roger Tseng
2013-02-04 11:57 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txpipwja.fsf@octavius.laptop.org \
--to=cjb@laptop.org \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox