From: Andi Kleen <andi@firstfloor.org>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: backwards busy wait using "time_before()"??
Date: Fri, 01 Jan 2010 16:17:07 +0100 [thread overview]
Message-ID: <87tyv57t3g.fsf@basil.nowhere.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0912311136560.3596@localhost> (Robert P. J. Day's message of "Thu, 31 Dec 2009 11:40:42 -0500 (EST)")
"Robert P. J. Day" <rpjday@crashcourse.ca> writes:
> cpu_relax(); \
> } while (time_before(end_jiffies, jiffies)); \
> succeeded; \
> })
>
>
> is it just me, or do those arguments to time_before() look
> backwards?
Yes it looks backwards. The timeout path probably has been never
tested.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
prev parent reply other threads:[~2010-01-01 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 16:40 backwards busy wait using "time_before()"?? Robert P. J. Day
2009-12-31 19:23 ` Robert P. J. Day
2010-01-01 15:17 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyv57t3g.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox