From: Kevin Hilman <khilman@deeprootsystems.com>
To: felipe.balbi@nokia.com
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"wim\@iguana.be" <wim@iguana.be>
Subject: Re: [PATCH] watchdog: davinci: convert to ioremap() + io[read|write]
Date: Thu, 05 Feb 2009 10:13:47 -0800 [thread overview]
Message-ID: <87tz784uqs.fsf@deeprootsystems.com> (raw)
In-Reply-To: <20090205173810.GE10567@scadufax.research.nokia.com> (Felipe Balbi's message of "Thu\, 5 Feb 2009 19\:38\:10 +0200")
Felipe Balbi <felipe.balbi@nokia.com> writes:
> On Thu, Feb 05, 2009 at 06:26:22PM +0100, Kevin Hilman wrote:
>> + wdt_base = ioremap(res->start, res->end);
>
> second argument should be size right ??
>
> ioremap(res->start, res->end - res->start + 1);
>
> in fact you have a size variable in this driver used for
> request_mem_region() just be sure the value is still valid and use it
> ;-)
doh.
>> + if (!wdt_base) {
>> + printk(KERN_ERR MODULE_NAME "failed to map memory region\n");
>
> you have a dev pointer in platform_device would be cool
> to use dev_err() here
sounds good, I'll convert the rest of the printk(KERN_* into dev_* as well.
Kevin
next prev parent reply other threads:[~2009-02-05 18:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 17:26 [PATCH] watchdog: davinci: convert to ioremap() + io[read|write] Kevin Hilman
2009-02-05 17:38 ` Felipe Balbi
2009-02-05 18:13 ` Kevin Hilman [this message]
2009-02-05 18:27 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tz784uqs.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox