public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Elias Oltmanns <eo@nebensachen.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Dave Chinner <david@fromorbit.com>,
	xfs-masters@oss.sgi.com, Jeremy Fitzhardinge <jeremy@goop.org>,
	Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	Kyle Moffett <mrmacman_g4@mac.com>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	David Chinner <dgc@sgi.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [xfs-masters] Re: freeze vs freezer
Date: Tue, 01 Jul 2008 17:05:29 +0200	[thread overview]
Message-ID: <87tzf9hcg6.fsf@denkblock.local> (raw)
In-Reply-To: 200807011635.44696.rjw@sisk.pl

"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> On Tuesday, 1 of July 2008, Dave Chinner wrote:
>> On Tue, Jul 01, 2008 at 12:38:41AM +0200, Rafael J. Wysocki wrote:
>
>> > On Tuesday, 1 of July 2008, Dave Chinner wrote:
>> > > On Mon, Jun 30, 2008 at 11:00:43PM +0200, Rafael J. Wysocki wrote:
>> > > > On Monday, 30 of June 2008, Dave Chinner wrote:
[...]
>> > > > > What do you do with a sync I/O (read or write)? The 
>> > > > > process is going to have to go to sleep somewhere in D state waiting
>> > > > > for that I/O to complete.  If you're going to intercept such
>> > > > > processes somewhere else to do something magic, then why not put
>> > > > > that magic in vfs_check_frozen()?
>> > > > 
>> > > > This might work too, but it would be nice to do something independent of the
>> > > > freezer, so that we can drop the freezer when we want and not when we are
>> > > > forced to.
>> > > 
>> > > vfs_check_frozen() is completely independent of the process freezer.
>> > 
>> > Well, can you please tell me how exactly that works, then?
>> 
>> Try looking at the code. When we freeze a filesystem sb->s_frozen
>> changes state depending on the level of freeze currently obtained
>> by the filesystem. And:
>> 
>> #define vfs_check_frozen(sb, level) \
>>         wait_event((sb)->s_wait_unfrozen, ((sb)->s_frozen < (level)))
>> 
>> Pretty bloody simple, really.
>
> OK
>
> Do all of the filesystems implement the freezing?

There is some work in progress [1]. If you think this will help you to
address this issue on the fs level, where I think it should be done, you
may even be able to request some changes to fit your needs before it
gets merged into mainline.

Regards,

Elias

[1] http://permalink.gmane.org/gmane.linux.file-systems/24716

  reply	other threads:[~2008-07-01 15:07 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-22  3:54 freeze vs freezer Jeremy Fitzhardinge
2007-11-23 23:47 ` Rafael J. Wysocki
2007-11-26 18:44   ` Jeremy Fitzhardinge
2007-11-26 21:20     ` Rafael J. Wysocki
2007-11-26 21:17   ` David Chinner
2007-11-26 21:53     ` Rafael J. Wysocki
2007-11-27  5:38       ` Matthew Garrett
2007-11-27 17:40         ` Rafael J. Wysocki
2007-11-27 20:33           ` Kyle Moffett
2007-11-27 23:01             ` Rafael J. Wysocki
2007-11-27 22:49               ` Jeremy Fitzhardinge
2007-11-27 23:14                 ` Kyle Moffett
2007-11-27 23:32                   ` Jeremy Fitzhardinge
2008-01-02 16:02             ` Pavel Machek
2008-01-02 21:30               ` Nigel Cunningham
2008-01-02 22:04                 ` Rafael J. Wysocki
2008-01-03  9:19                   ` Nigel Cunningham
2008-01-03  9:47                     ` Oliver Neukum
2008-01-03  9:52                       ` Nigel Cunningham
2008-01-03 11:15                         ` Oliver Neukum
2008-01-03 22:06                           ` Nigel Cunningham
2008-01-04 20:54                             ` Oliver Neukum
2008-01-05  1:38                               ` Kyle Moffett
2008-01-05 21:18                               ` Pavel Machek
2008-01-05 23:01                                 ` Nigel Cunningham
2008-01-03 22:31                     ` Rafael J. Wysocki
2008-06-23  7:16             ` Pavel Machek
2008-06-23 14:00               ` Henrique de Moraes Holschuh
2008-06-24  8:08                 ` Elias Oltmanns
2008-06-26 15:09                   ` Pavel Machek
2008-06-29 22:12                     ` [xfs-masters] " Dave Chinner
2008-06-29 23:22                       ` Rafael J. Wysocki
2008-06-30  6:11                         ` Christoph Hellwig
2008-06-30 20:34                           ` Rafael J. Wysocki
2008-07-03 19:43                             ` Eric Sandeen
2008-06-30  6:29                         ` Dave Chinner
2008-06-30  6:37                           ` Jeremy Fitzhardinge
2008-06-30 12:33                             ` Dave Chinner
2008-06-30 21:00                               ` Rafael J. Wysocki
2008-06-30 22:21                                 ` Dave Chinner
2008-06-30 22:38                                   ` Rafael J. Wysocki
2008-07-01  6:38                                     ` Dave Chinner
2008-07-01 14:35                                       ` Rafael J. Wysocki
2008-07-01 15:05                                         ` Elias Oltmanns [this message]
2008-07-01 15:17                                           ` Christoph Hellwig
2008-07-01 21:15                                           ` Dave Chinner
2008-07-01 21:46                                             ` Elias Oltmanns
2008-07-01 21:12                                         ` Dave Chinner
2008-07-01 21:21                                           ` Rafael J. Wysocki
2008-07-01  8:59                             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tzf9hcg6.fsf@denkblock.local \
    --to=eo@nebensachen.de \
    --cc=david@fromorbit.com \
    --cc=dgc@sgi.com \
    --cc=hmh@hmh.eng.br \
    --cc=jens.axboe@oracle.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=mrmacman_g4@mac.com \
    --cc=rjw@sisk.pl \
    --cc=xfs-masters@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox