From: Julien BLACHE <jb@jblache.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
rpurdie@rpsys.net, linux-kernel@vger.kernel.org,
mzxreary@0pointer.de
Subject: Re: [PATCH v2] Add backlight driver for Nvidia-based Apple Macbook Pros
Date: Sat, 07 Jun 2008 16:45:41 +0200 [thread overview]
Message-ID: <87tzg5tiay.fsf@sonic.technologeek.org> (raw)
In-Reply-To: <20080607100117.GB803@srcf.ucam.org> (Matthew Garrett's message of "Sat, 7 Jun 2008 11:01:17 +0100")
Matthew Garrett <mjg59@srcf.ucam.org> wrote:
Hi,
> Signed-off-by: Matthew Garrett <mjg@redhat.com>
If you need it, here you have it:
Signed-off-by: Julien Blache <jb@jblache.org>
Minor nitpicks follow:
> +config BACKLIGHT_MBP_NVIDIA
> + tristate "Macbook Pro Nvidia Backlight Driver"
^^^^^^^
Proper capitalization is "MacBook", also to be consistent with other
help texts in the kernel (I hope).
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
This particular file in pommed is GPL v2 or later; it's external
code I included in pommed and the original license was GPL v2 or
later.
JB.
--
Julien BLACHE <http://www.jblache.org>
<jb@jblache.org> GPG KeyID 0xF5D65169
next prev parent reply other threads:[~2008-06-07 14:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 2:54 [PATCH] Add backlight driver for Nvidia-based Apple Macbook Pros Matthew Garrett
2008-06-07 5:04 ` Andrey Panin
2008-06-07 6:07 ` Andrew Morton
2008-06-07 9:58 ` Matthew Garrett
2008-06-07 10:05 ` Pekka Enberg
2008-06-07 10:14 ` Matthew Garrett
2008-06-07 10:50 ` Pekka Enberg
2008-06-07 18:59 ` Andrew Morton
2008-06-07 10:01 ` [PATCH v2] " Matthew Garrett
2008-06-07 14:45 ` Julien BLACHE [this message]
2008-06-08 18:32 ` [PATCH] " Lennart Poettering
2008-06-09 0:03 ` Matthew Garrett
2008-06-09 0:05 ` [PATCH v2] " Matthew Garrett
2008-06-09 20:59 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tzg5tiay.fsf@sonic.technologeek.org \
--to=jb@jblache.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=mzxreary@0pointer.de \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox