From: Nam Cao <namcao@linutronix.de>
To: Xiaofeng Yuan <xiaofengmian@163.com>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Cc: Alexandre Ghiti <alex@ghiti.fr>, Mark Brown <broonie@kernel.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
xiaofengmian@163.com
Subject: Re: [PATCH 1/2] riscv: mm: make EXECMEM_KPROBES writable without ARCH_HAS_EXECMEM_ROX
Date: Fri, 17 Jul 2026 12:46:37 +0200 [thread overview]
Message-ID: <87v7adx59u.fsf@yellow.woof> (raw)
In-Reply-To: <20260701102822.95459-2-xiaofengmian@163.com>
Xiaofeng Yuan <xiaofengmian@163.com> writes:
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index 5b1b3c88b..21794e7bb 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -1457,7 +1457,9 @@ struct execmem_info __init *execmem_arch_setup(void)
> [EXECMEM_KPROBES] = {
> .start = VMALLOC_START,
> .end = VMALLOC_END,
> - .pgprot = PAGE_KERNEL_READ_EXEC,
> + .pgprot = IS_ENABLED(CONFIG_ARCH_HAS_EXECMEM_ROX) ?
> + PAGE_KERNEL_READ_EXEC :
> + PAGE_KERNEL_EXEC,
> .alignment = 1,
> },
> [EXECMEM_BPF] = {
CONFIG_ARCH_HAS_EXECMEM_ROX=n for RISC-V, so this is just
.pgprot = PAGE_KERNEL_EXEC,
Since this is only needed when CONFIG_STRICT_MODULE_RWX=n, shouldn't the
condition be based on that instead?
Nam
next prev parent reply other threads:[~2026-07-17 10:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 10:28 [PATCH 0/2] riscv: fix kprobes on minimal kernel configs Xiaofeng Yuan
2026-07-01 10:28 ` [PATCH 1/2] riscv: mm: make EXECMEM_KPROBES writable without ARCH_HAS_EXECMEM_ROX Xiaofeng Yuan
2026-07-17 10:46 ` Nam Cao [this message]
2026-07-01 10:28 ` [PATCH 2/2] riscv: patch: skip fixmap mapping when kernel text is already writable Xiaofeng Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7adx59u.fsf@yellow.woof \
--to=namcao@linutronix.de \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=xiaofengmian@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox