From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37BA51D5160 for ; Fri, 3 Jul 2026 21:37:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.70.13.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783114646; cv=none; b=eS8ZjtkSk6tGXJD4g4R0eDj/VatJKccK1z5oN9IA98a3UkLDDVPzaeHtBInqskqk38BDakLXiJFojUhPntQcefn5wLiBRdJOXHCNQXR01C58q3PH2CrDv9eFrZl4P+oobgl1NMXhZa3Zqrw715ZHjPwnw0nJ9e8P4BZtsORVGgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783114646; c=relaxed/simple; bh=VTRG/jhHGqcQscHwtDTroH+eOyhe/ChmTNQUBp9XOQI=; h=From:To:Cc:In-Reply-To:References:Date:Message-ID:MIME-Version: Content-Type:Subject; b=Csr7tNaLfFUiQL/aEXHaSMy2Ydo/KaN6NVkCidLRkZIfVUtQAyrHmw6hbtSB700dwEy/qtYLjiBt6JUX/n0pyuRZegUTw3BgwpJKVA1zWIEY+ntqgQ7XdZCdY9PB0Y+DY9sJT8YZuk17ykXHONJ6puwXgIHuZC7uLsOKuMfmXS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com; spf=pass smtp.mailfrom=xmission.com; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b=BiQO7s1m; arc=none smtp.client-ip=166.70.13.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xmission.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xmission.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xmission.com header.i=@xmission.com header.b="BiQO7s1m" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=xmission.com; s=xmission; h=Subject:Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VTRG/jhHGqcQscHwtDTroH+eOyhe/ChmTNQUBp9XOQI=; b=BiQO7s1mh9WwsUAh2frVqUuASv I5pk4kL/aEOZJWvFRb96RkVoi6LyniT+B5QfrskHQJ2utWj8jLTWbxXuvPVLCdv4xJ9No9bAjsZ1Z 8CA5mVVsZG2wkT7fDQFN8iW3oEXzi5aVjHP7fNn69e5VpnZjwembjrb2bydX0Jmg01M4=; Received: from in01.mta.xmission.com ([166.70.13.51]:55086) by out02.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wflZc-003G5i-JG; Fri, 03 Jul 2026 15:37:24 -0600 Received: from ip72-198-198-28.om.om.cox.net ([72.198.198.28]:57546 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1wflZa-00Dm6J-64; Fri, 03 Jul 2026 15:37:24 -0600 From: "Eric W. Biederman" To: Oleg Nesterov Cc: Andrew Morton , Andy Lutomirski , Kees Cook , Kusaram Devineni , Peter Zijlstra , Thomas Gleixner , Will Drewry , linux-kernel@vger.kernel.org, Linus Torvalds , Christian Brauner In-Reply-To: <877bnb4uyw.fsf_-_@email.froward.int.ebiederm.org> (Eric W. Biederman's message of "Fri, 03 Jul 2026 16:35:51 -0500") References: <87o6gx9rc4.fsf@email.froward.int.ebiederm.org> <877bnh7tnf.fsf@email.froward.int.ebiederm.org> <877bnb4uyw.fsf_-_@email.froward.int.ebiederm.org> Date: Fri, 03 Jul 2026 16:37:16 -0500 Message-ID: <87v7av3gc3.fsf_-_@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1wflZa-00Dm6J-64;;;mid=<87v7av3gc3.fsf_-_@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=72.198.198.28;;;frm=ebiederm@xmission.com;;;sPfnum=0;;;sPf=pass X-XM-AID: U2FsdGVkX19KzNVn+bM2QmV8SknCVPUuK1x+MRpc6Nw= X-Spam-Level: * X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.1 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4857] * 0.7 XMSubLong Long Subject * 1.5 XMNoVowels Alpha-numberic number with no vowels * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa06 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa06 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Oleg Nesterov X-Spam-Relay-Country: X-Spam-Timing: total 1966 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 11 (0.6%), b_tie_ro: 10 (0.5%), parse: 1.12 (0.1%), extract_message_metadata: 13 (0.7%), get_uri_detail_list: 1.29 (0.1%), tests_pri_-2000: 12 (0.6%), tests_pri_-1000: 2.6 (0.1%), tests_pri_-950: 1.18 (0.1%), tests_pri_-900: 0.97 (0.0%), tests_pri_-90: 47 (2.4%), check_bayes: 46 (2.3%), b_tokenize: 6 (0.3%), b_tok_get_all: 4.8 (0.2%), b_comp_prob: 1.68 (0.1%), b_tok_touch_all: 30 (1.5%), b_finish: 0.82 (0.0%), tests_pri_0: 231 (11.8%), check_dkim_signature: 0.49 (0.0%), check_dkim_adsp: 2.9 (0.1%), poll_dns_idle: 1629 (82.9%), tests_pri_10: 2.8 (0.1%), tests_pri_500: 1640 (83.4%), rewrite_mail: 0.00 (0.0%) Subject: [PATCH 02/14] signal: Factor out sig_blocked from sig_ignored X-SA-Exim-Connect-IP: 166.70.13.51 X-SA-Exim-Rcpt-To: brauner@kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, wad@chromium.org, tglx@kernel.org, peterz@infradead.org, kusaram@devineni.in, kees@kernel.org, luto@kernel.org, akpm@linux-foundation.org, oleg@redhat.com X-SA-Exim-Mail-From: ebiederm@xmission.com X-SA-Exim-Scanned: No (on out02.mta.xmission.com); SAEximRunCond expanded to false Add a helper that spells out the logic of why both blocked and real_blocked need to be consulted to see if a signal is blocked. Signed-off-by: Eric W. Biederman --- kernel/signal.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/kernel/signal.c b/kernel/signal.c index 6b49bae3fce7..1a8183606dc0 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -103,6 +103,25 @@ static bool sig_task_ignored(struct task_struct *t, int sig, bool force) return sig_handler_ignored(handler, sig); } +static bool sig_blocked(struct task_struct *t, int sig) +{ + /* + * Is calling the signal handler blocked? + * + * Two sigsets need to be consulted to see if the userspace + * signal handler can be invoked: thread->blocked and + * thread->real_blocked. Ordinarily thread->blocked contains + * all of the information and thread->real_blocked is empty. + * + * When thread->real_blocked is in use it contains the actual + * information on which signal handlers can not be invoked and + * thread->blocked has a subset of the signals contained in + * thread->real_blocked. + */ + return sigismember(&t->blocked, sig) || + sigismember(&t->real_blocked, sig); +} + static bool sig_ignored(struct task_struct *t, int sig, bool force) { /* @@ -110,7 +129,7 @@ static bool sig_ignored(struct task_struct *t, int sig, bool force) * signal handler may change by the time it is * unblocked. */ - if (sigismember(&t->blocked, sig) || sigismember(&t->real_blocked, sig)) + if (sig_blocked(t, sig)) return false; /* -- 2.41.0