From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B83A26158B for ; Fri, 5 Jun 2026 05:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780635773; cv=none; b=lmOjLjnTzGOzUAp478T6JZC4SQEFKxMl/T98/Ks3c0/M1+hFLgJHb/93GVZf6s8zalxgHkj4Acd+A8lBmo+1BUnGZVqaLruV2OCH++ORcmQh+blSOIb+k4C/DYJpRAhAI78l1ZGexvh8nTNh4fj5HOseJMfc2+krIwoWgQ2Vdt8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780635773; c=relaxed/simple; bh=6Mhl8KmIdInKaC12+xQLU0FoCvJVhrND8e1AJkW4CRM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=r7M5JoweVu5cYTYuyzc/9o2Kyda/dbabYOkFEnEaTk9WkQJJf6oX6PgGOK2mGkIIT4ZTEVzs2kBISvaXU8ds2bNBtYhhByrED6mfPQDmH51waEGxEtdHl4UZAUIM2foMFD8UY7US1/Eb4/OI2V08+/qdEZW6K/TFzfgQBY2akdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=uKs50B31; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="uKs50B31" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 49C951A0876 for ; Fri, 5 Jun 2026 05:02:48 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0B3E75FED1; Fri, 5 Jun 2026 05:02:48 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A3FEC106A1E99; Fri, 5 Jun 2026 07:02:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780635767; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=6Mhl8KmIdInKaC12+xQLU0FoCvJVhrND8e1AJkW4CRM=; b=uKs50B31sBCzyWVpMzKJFPUGvDS0f1FJ8ZJhPiYsQAMXy1l8UzmhpZnULJE99LP6tumWoY /MGJzzqg/HCsSoDtpa9RK8xx27kHE0mtxKkZg7NQkVLsprF9Y8bhTw8i9ng7NCk7KJj+eO Hb5o07bHxbqqZF2UHnbV1POvuRB79rWk70eLY9zulXepNTSsdlTdcVeMXkvwASs3MyyGhH 46CGiTW9/snEeBC20MkYXfIWB1rHfRWxxC9ft2lhKyU15Xguc5+v6/qtaAQHjlbSR26qfV vU4Q8SEGmDSwdVCgLMZHnoeCSDogVPOPmj4upwXfuVRv2B/HWyyoRKbbzu6atg== From: Miquel Raynal To: Cheng Ming Lin Cc: Pratyush Yadav , Michael Walle , Takahiro Kuwano , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, Cheng Ming Lin Subject: Re: [PATCH v2 1/2] mtd: spi-nor: Add support for MX25L12833F and MX25L12845G In-Reply-To: <20260605005720.1857413-2-linchengming884@gmail.com> (Cheng Ming Lin's message of "Fri, 5 Jun 2026 08:57:19 +0800") References: <20260605005720.1857413-1-linchengming884@gmail.com> <20260605005720.1857413-2-linchengming884@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Fri, 05 Jun 2026 07:02:38 +0200 Message-ID: <87v7bxwpe9.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Hello Cheng Ming, On 05/06/2026 at 08:57:19 +08, Cheng Ming Lin w= rote: > From: Cheng Ming Lin > > Add support for Macronix MX25L12833F and MX25L12845G SPI NOR flashes. > These parts share the same JEDEC ID (0xc2, 0x20, 0x18) as the legacy > MX25L12805D. > > The newer flashes support SFDP and 1-4-4 Page Program in 3-byte address > mode, but this 4PP capability is not defined in their SFDP tables. > Conversely, the legacy MX25L12805D lacks SFDP support entirely and does > not support 4PP. > > To safely enable 4PP for the newer flashes without breaking the legacy > part, introduce a post_bfpt fixup. Since the legacy MX25L12805D does > not support SFDP, it falls back to static parameters and will never > execute the post_bfpt hook. The newer flashes will successfully parse > the BFPT, trigger the hook, and safely append the SNOR_HWCAPS_PP_1_4_4 > capability. > > Signed-off-by: Cheng Ming Lin LGTM. Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l