From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0E5732AAAB for ; Wed, 27 May 2026 12:29:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779884995; cv=none; b=dZ7t8SaHmPk3IKScFNw1TSg6A8EZDGDOF46hgLda2LzuF3AGfjN2zLwDANq09oiBUrTSnVC/5CkOnDJxirdr0HSskUxinYU2k3uMw8ZXUcf/YXrGMtrCHFZPMSkdmqYcgtPPPECdzeXkC5jx1C+HJT64otjrw0SH29PaOumgx7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779884995; c=relaxed/simple; bh=N+8YBejrHjBsdboflGClPTY4sYaY4yzigIJcJZFRdKQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=OuICECQbancn2MW5525EB2AuV0z59X6ed1PFNfpFtYkR51AmuhXlD0maOEV8NxatUptpw7A91lQfvrxdEQjH5pizLnuiHc+/9MplOr0C0NVaNBOu6+raCaX4TFGyNxTP0RuEC4Ba9ppXSFMOImaZNMZilfZYZU0tBCBzXtUyHDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=TcCuC7b/; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="TcCuC7b/" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C98FF1A36ED; Wed, 27 May 2026 12:29:42 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 94EDE601A1; Wed, 27 May 2026 12:29:42 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DF12C10888060; Wed, 27 May 2026 14:29:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1779884982; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=QZ113z6If22F9e7yLjEYBGa8nC6AiS+7y7cHO6FwrLw=; b=TcCuC7b/TXN+rKfVRcGh3hgYCx88DnANr3Ht11vtP3a3dTHDoUEhm48zZvp/HGk+rzrahp SksbeZ/R9YwN9diBFa5eMF1DzDu790CLc5/myv594+VUub+tc2hDOLFZaitE8c3q8znsxl ntM9vux5zKobcn1710W0qRYnsVzIb4+eeE9VTXA6NJSUdRO5w4N6a53Z0fvEseiFJaZ7rL WO56fPDRf2utMqPyYJeEpLAEo9o59Es9VvJYxIxf5NOREkzZJ1pj0RrGbHLLJphd+vYbgi XtrXAE/5UHll4VJSkx8LoibBtzY6RcXHjSkM0J+1bkfeeLihL/e3I5XV6GE+lw== From: Miquel Raynal To: Qing Wu Cc: Michal Simek , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mtd: spinand: dosilicon: Add support for additional models In-Reply-To: <20260527100021.76247-1-ses1er@gmail.com> (Qing Wu's message of "Wed, 27 May 2026 06:00:21 -0400") References: <20260527100021.76247-1-ses1er@gmail.com> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Wed, 27 May 2026 14:29:39 +0200 Message-ID: <87v7c9hw7g.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 27/05/2026 at 06:00:21 -04, Qing Wu wrote: > Add support for additional Dosilicon SPI NAND chips. > > Datasheets for chips included in this patch: https://www.dosilicon.com/SP= I%20NAND%20Flash.html > > Tested on a TP-Link TL-7DR7250 with a Dosilicon DS35Q1GB (0xE5 0xF1) > > Signed-off-by: Qing Wu > --- > Changes in v3: > - Changed title > - Updated 2 bytes for BBM > - Link to v2: https://lore.kernel.org/all/20260520003733.82514-1-ses1er@g= mail.com/ > Changes in v2: > - Fixed compilation errors. > - Link to v1: https://lore.kernel.org/all/20260217211427.9120-1-ses1er@gm= ail.com > --- > drivers/mtd/nand/spi/dosilicon.c | 218 ++++++++++++++++++++++++++++--- > 1 file changed, 203 insertions(+), 15 deletions(-) > > diff --git a/drivers/mtd/nand/spi/dosilicon.c b/drivers/mtd/nand/spi/dosi= licon.c > index f99899866ceb..fcd967c1bcbc 100644 > --- a/drivers/mtd/nand/spi/dosilicon.c > +++ b/drivers/mtd/nand/spi/dosilicon.c > @@ -9,21 +9,27 @@ >=20=20 > #define SPINAND_MFR_DOSILICON 0xE5 >=20=20 > +#define DOSICON_STATUS_ECC_MASK GENMASK(6, 4) > +#define DOSICON_STATUS_ECC_NO_BITFLIPS (0 << 4) > +#define DOSICON_STATUS_ECC_1TO3_BITFLIPS (1 << 4) > +#define DOSICON_STATUS_ECC_4TO6_BITFLIPS (3 << 4) > +#define DOSICON_STATUS_ECC_7TO8_BITFLIPS (5 << 4) > + > static SPINAND_OP_VARIANTS(read_cache_variants, > - SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0), > - SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0), > - SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0), > - SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0)); > + SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0), > + SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0)); Spurious changes? This cannot be even compile tested. Please don't rush your v4. Also please run get_maintainers.pl, the Cc list is not complete. Thanks, Miqu=C3=A8l