From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>,
Chris J Arges <chris.j.arges@canonical.com>,
Detlef Urban <onkel@paraair.de>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 0/4] usb-audio: fix mixer write failure handling
Date: Tue, 21 Apr 2026 10:09:20 +0200 [thread overview]
Message-ID: <87v7dkag5r.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260419-usb-write-error-propagation-v1-0-5a3bd4a673ae@gmail.com>
On Sun, 19 Apr 2026 22:30:28 +0200,
Cássio Gabriel wrote:
>
> This series fixes usb-audio mixer put() paths that currently report
> success even when the underlying device write fails.
>
> The issue exists in the generic mixer core callbacks, the Scarlett
> Gen1 enum path, and several Tascam US-16x08 put() callbacks.
>
> The US-16x08 EQ and compressor callbacks have an additional bug: they
> update their software shadow state before sending the USB write, so a
> failed transfer can leave later get() results out of sync with the
> hardware state.
>
> The series is split into four patches:
> - propagate write failures in the generic mixer core callbacks
> - fix the Scarlett Gen1 enum callback
> - propagate write failures in the simple US-16x08 put() callbacks
> - commit the US-16x08 EQ and compressor shadow state only after a
> successful write
>
> Successful writes are unchanged. Failed writes are now reported
> correctly, and the US-16x08 shadow state remains coherent with the
> hardware after write errors.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
As this might influence on the actual device behavior significantly,
and it's in a merge window, I postpone the series for 7.2.
thanks,
Takashi
next prev parent reply other threads:[~2026-04-21 8:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 20:30 [PATCH 0/4] usb-audio: fix mixer write failure handling Cássio Gabriel
2026-04-19 20:30 ` [PATCH 1/4] ALSA: usb-audio: Propagate write errors in generic mixer put callbacks Cássio Gabriel
2026-04-19 20:30 ` [PATCH 2/4] ALSA: usb-audio: Propagate errors in scarlett_ctl_enum_put() Cássio Gabriel
2026-04-19 20:30 ` [PATCH 3/4] ALSA: usb-audio: Propagate US-16x08 write errors in route/mix EQ-switch put callbacks Cássio Gabriel
2026-04-19 20:30 ` [PATCH 4/4] ALSA: usb-audio: Update US-16x08 EQ/comp shadow state after successful writes Cássio Gabriel
2026-04-21 8:09 ` Takashi Iwai [this message]
2026-04-21 12:14 ` [PATCH 0/4] usb-audio: fix mixer write failure handling Cássio Gabriel Monteiro Pires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7dkag5r.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=chris.j.arges@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=onkel@paraair.de \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox