Re: [RFC PATCH v3 1/8] fuse: simplify fuse_lookup_name() interface

Luis Henriques
2026-02-28T14:42:46Z

On Fri, Feb 27 2026, Miklos Szeredi wrote:

> On Wed, 25 Feb 2026 at 12:25, Luis Henriques <luis@igalia.com> wrote:
>
>> @@ -570,30 +571,34 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
>> attr_version = fuse_get_attr_version(fm->fc);
>> evict_ctr = fuse_get_evict_ctr(fm->fc);
>>
>> - fuse_lookup_init(fm->fc, &args, nodeid, name, outarg);
>> + fuse_lookup_init(fm->fc, &args, nodeid, name, &outarg);
>> err = fuse_simple_request(fm, &args);
>> /* Zero nodeid is same as -ENOENT, but with valid timeout */
>> - if (err || !outarg->nodeid)
>> + if (err || !outarg.nodeid)
>> goto out_put_forget;
>
> And now the timeout is skipped for the !outarg.nodeid case...

Oops, yeah I missed that. I'll fix it for the next iteration, thanks!

Cheers,
--
Luís