From: Thomas Gleixner <tglx@kernel.org>
To: Luigi Rizzo <lrizzo@google.com>
Cc: Eric Dumazet <edumazet@google.com>, Marc Zyngier <maz@kernel.org>,
Luigi Rizzo <rizzo.unipi@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] genirq: move clear of kstat_irqs to free_desc()
Date: Tue, 13 Jan 2026 10:31:01 +0100 [thread overview]
Message-ID: <87v7h5eu5m.ffs@tglx> (raw)
In-Reply-To: <CAMOZA0Ld81_W9tECpgM_Z3iH5v_Gvh5ngT6HiTp7SR=pvAJryw@mail.gmail.com>
On Tue, Jan 13 2026 at 10:21, Luigi Rizzo wrote:
> On Tue, Jan 13, 2026, 10:09 Thomas Gleixner <tglx@kernel.org> wrote:
>> Right, though it really does not matter unless you deeply care about:
>>
>> alpha, arc, hexagon, m68k, mips, parisc, sparc, xtensa and random old
>> ARM32 platforms :)
>>
>
> Purely academic question: I suppose the lock is just to make sure that
> there isn't anyone currently using the descriptor before marking it
> disabled; but is it really needed, or by the time the function is called it
> is already known that it is not in use anymore?
It's still accessible through the array and while it's probably
irrelevant, I have no intention to audit all the legazy architecture
code for random abuse. At least the removed itanium code did nasty
things with them behind the core.
Thanks,
tglx
next prev parent reply other threads:[~2026-01-13 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 8:32 [PATCH v2] genirq: move clear of kstat_irqs to free_desc() Luigi Rizzo
2026-01-12 20:18 ` Eric Dumazet
2026-01-13 9:09 ` Thomas Gleixner
[not found] ` <CAMOZA0Ld81_W9tECpgM_Z3iH5v_Gvh5ngT6HiTp7SR=pvAJryw@mail.gmail.com>
2026-01-13 9:31 ` Thomas Gleixner [this message]
2026-01-13 9:17 ` [tip: irq/core] genirq: Move " tip-bot2 for Luigi Rizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7h5eu5m.ffs@tglx \
--to=tglx@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrizzo@google.com \
--cc=maz@kernel.org \
--cc=rizzo.unipi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox