From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2409272E6D for ; Thu, 8 Jan 2026 21:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767908358; cv=none; b=W+mvDs4j88viDtecBxMqOLIQ4RaOCmoWu9BcqGa+rtYjF2FM0YFRWwsHGkL0nMpuhROdutyK7f7lI3YHMgej+EkSOllnrdzvYzJFvInAdy2isGVdWJe+8niDPPJm2rG23QrrM4cxLyOWSD4ra5zh0t1plYIFxJfJ7CvzstQhNEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767908358; c=relaxed/simple; bh=oWkhb/RqXCYQAa7A6ssQr/COfIjx5IaLOdC4D8lf8yw=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=GnidwuVC4uEiUzBn1PXnXouUaplwQRjgUCkNt0it4lZkzVNLEOfwjj7BNYVZDIeAALOJT7mB1nwyrkLHOoflX4gELO1/0Ici+PKoGKzhg0G+fXtXq7at8iD/QRgFeW22JZ5l6DukuIP4XpZMLA5Qiq8NFva7GewiyDZru9xXXpk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ov4padQg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ov4padQg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4FB3C116C6; Thu, 8 Jan 2026 21:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767908358; bh=oWkhb/RqXCYQAa7A6ssQr/COfIjx5IaLOdC4D8lf8yw=; h=From:To:Subject:In-Reply-To:References:Date:From; b=ov4padQg5DCVFH0q0OFFSonYOvsP5rOnJSzuWef2iVSTPBz/j9k7wWF1HLtHBobAh afvJKsY94kRJsynYYiuYpPtKqquioLE28ymAxmqJF13suMKEZVumIcJ878PhHKbFTJ 5or0uVRml/kcHVV+WXnfenRU+87Who8gdh0gAYSJiUoz31JbWWA0MvroIjNsGzubKt f+Wy9+w6dR39w9ph7/KH4lrjkBmSUqq0Oy16JvjGdn2dALBELYBx3MYH43zII1sLJ7 +2iVwyPCitxKf1dxmX9l0GkH6M/BYHs8OP7iMPt6fKLJRdMjn7OsHMiJSraLxRVHra Zm1mL7iKmtcPw== From: Thomas Gleixner To: "enlin.mu" , bigeasy@linutronix.de, boqun.feng@gmail.com, mingo@kernel.org, ryotkkr98@gmail.com, linux-kernel@vger.kernel.org, enlin.mu@unisoc.com Subject: Re: [PATCH] softirq: Print the function name In-Reply-To: <252851c4-c7a0-49b1-9fca-f1bac04b588f@linux.dev> References: <20260105094133.3542-1-enlin.mu@linux.dev> <252851c4-c7a0-49b1-9fca-f1bac04b588f@linux.dev> Date: Thu, 08 Jan 2026 22:39:14 +0100 Message-ID: <87v7hbss1p.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Jan 06 2026 at 14:16, enlin.mu wrote: > On 2026/1/5 17:41, Enlin Mu wrote: >> Adjust the printing format from the function address to >> the function name. >> >> Signed-off-by: Enlin Mu >> Signed-off-by: Enlin Mu >> --- >> kernel/softirq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/softirq.c b/kernel/softirq.c >> index 77198911b8dd..68ef18616fb9 100644 >> --- a/kernel/softirq.c >> +++ b/kernel/softirq.c >> @@ -622,7 +622,7 @@ static void handle_softirqs(bool ksirqd) >> h->action(); >> trace_softirq_exit(vec_nr); >> if (unlikely(prev_count != preempt_count())) { >> - pr_err("huh, entered softirq %u %s %p with preempt_count %08x, exited with %08x?\n", >> + pr_err("huh, entered softirq %u %s %pS with preempt_count %08x, exited with %08x?\n", >> vec_nr, softirq_to_name[vec_nr], h->action, >> prev_count, preempt_count()); > > Hi All > > My test results are as follows: > > before this patch: > > [ 49.919574] softirq: huh, entered softirq 1 TIMER 00000000bb45ef3a > with preempt_count 00000101, exited with 00000101? > > > after this patch: > > [ 49.919570] softirq: huh, entered softirq 1 TIMER > run_timer_softirq+0x0/0x108 with preempt_count 00000101, exited with > 00000102? The TIMER softirq always invoked run_timer_softirq(). If that happens then the interesting question is not the softirq action handler, but any function it invoked from there. So there is _zero_ value of adding this. Thanks, tglx