From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB8C27EFFA for ; Tue, 28 Oct 2025 16:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761668463; cv=none; b=LjwlOTj1R6E3kzuhCBk3jNAO9dhb7Rtr6rT6AhV8vcOFHBSTaML9B5RjEg05+D0o1X5qt4Q4NWBJ4QBwVaw1D/jTm98no9G5D2lzgD186ktn1sX3AZVmPHTldz9hO2CukcmZyKq4kBkI//5GNOcc2uaInbnUtY9vMXuNiIXYQzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761668463; c=relaxed/simple; bh=z2gmi5A9sdMhOB9KSfIt5x+ZIc+vGxgYVE8BEvo1P9M=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=pCQ+jDzESaAPkiEnZKa96bp21A4PoRtMTvNxV9ToL6z6rfSIN6o20FrsGPmEHyl/GYSJHr4yuqusnFTKiyd7+8edNyRd+zp7Ub2LcZrzeDZBLGmWrZ9uKEte/Ts6jsru4Y5RrZ2raLJNr/XLE70NfjE0JRWlta/auQTiC9aIRLM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=KCJnb7ZS; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="KCJnb7ZS" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 7148A1A170E; Tue, 28 Oct 2025 16:20:58 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 40FF0606AB; Tue, 28 Oct 2025 16:20:58 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 9DA7B117AC2F7; Tue, 28 Oct 2025 17:20:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761668457; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=z2gmi5A9sdMhOB9KSfIt5x+ZIc+vGxgYVE8BEvo1P9M=; b=KCJnb7ZSsKeg4swbTs2c0T6Pg/HT+ws9lWd6MSyvhjUkIl7Q6MhbEsl/T5zqMTATMJAGI9 +AcpEDrRx7loU39FZ/fM5LH4yxFqJEosm00gIDdispbgdjpE/aNCbUav02KAsaG7c/13jT gHJlm6Ea/1YV8NSJFbWcHzUCpgyxgxXA+eJqksWBGk7EGFLut/Z+1aKbo7ZoudjToC6PZD 84QFupfTS0L5VwpWLPVW++YDZoKCVqr1YoCfSWwVb74hAa8l3PV0jvm0EF+nnf5eTXRLwk taILyzLFkR6wt/aT5PaWbxhw9YFJwIHQJ6TnsjXc8197SvOSRQ9kkhOJdF/7rQ== From: Miquel Raynal To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Richard Genoud , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Wentao Liang , Johan Hovold , Maxime Ripard , Thomas Petazzoni , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 07/16] mtd: rawnand: sunxi: rework pattern found registers In-Reply-To: <6097267.MhkbZ0Pkbq@jernej-laptop> ("Jernej =?utf-8?Q?=C5=A0k?= =?utf-8?Q?rabec=22's?= message of "Tue, 28 Oct 2025 16:41:48 +0100") References: <20251028073534.526992-1-richard.genoud@bootlin.com> <20251028073534.526992-8-richard.genoud@bootlin.com> <6097267.MhkbZ0Pkbq@jernej-laptop> User-Agent: mu4e 1.12.7; emacs 30.2 Date: Tue, 28 Oct 2025 17:20:41 +0100 Message-ID: <87v7jz576u.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 On 28/10/2025 at 16:41:48 +01, Jernej =C5=A0krabec wrote: > Dne torek, 28. oktober 2025 ob 08:35:00 Srednjeevropski standardni =C4=8D= as je Richard Genoud napisal(a): >> On H6/H616, the register ECC_PAT_FOUND is at its own address, and not >> part of ECC status register. >> So, introduce the pattern found register offset in sunxi_nfc_caps, along >> with its mask. >>=20 >> Also, introduce a non compile-time field_get() because FIELD_GET() and >> u32_get_bits() don't work with non compile-time constant. >> https://lore.kernel.org/all/cover.1761588465.git.geert+renesas@glider.be > > Urls should use Link: tag and be placed at the bottom. I was about to apply, so I'll fix this while applying. > > Code itself looks fine. Thanks for the review! Miqu=C3=A8l