From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 868911ADFEA for ; Mon, 4 Nov 2024 09:29:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730712560; cv=none; b=Zg+9mWx6/xI/Om9JrLb/E50/EtAkDXiGe6Txu19mNb8MtTwMyzphlsQTDk+pzdNWF2kpxquCJmwD5Cl6l74dEPBVf+4cBKZ17xos/benLesy4aueE7B8Ri3gEBJJms1+HyglqLIoCyE8FUBzGAUO+ruWRemOOAPi3tfJNuyYBjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730712560; c=relaxed/simple; bh=NQdTQuUXttSeZskJgvBHkm84TGVBusiWG1zoAQ102s4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=AbtR42IoiwQNWq+S+POKDCDKvs/c01fU6X2KqCjL/mNpLkTO4wfpDwFDIEn1djZbYoOmaROvm1Uq0Tqfd/9EhDODaGY6yr4cJJpUX5lOhSO8FdRZkZOj39CLRZQ4XJwasTYi3WfP0f4om3JdAUvl5vTV4WPCF1vGByzY7J0tQ+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=ratatoskr.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t7tOR-0008L6-4O; Mon, 04 Nov 2024 10:29:03 +0100 From: Steffen Trumtrar To: Krzysztof Kozlowski Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dinh Nguyen , Richard Cochran , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, Teh Wen Ping Subject: Re: [PATCH 1/2] dt-bindings: clk: agilex5: Add Agilex5 clock bindings In-Reply-To: <5168bb64-f5cf-4cf4-81c9-3bbf0662a334@kernel.org> (Krzysztof Kozlowski's message of "Wed, 30 Oct 2024 15:36:09 +0100") References: <20241030-v6-12-topic-socfpga-agilex5-clk-v1-0-e29e57980398@pengutronix.de> <20241030-v6-12-topic-socfpga-agilex5-clk-v1-1-e29e57980398@pengutronix.de> <299bd27b-b5bd-492a-9873-447329e60b67@kernel.org> <5168bb64-f5cf-4cf4-81c9-3bbf0662a334@kernel.org> Date: Mon, 04 Nov 2024 10:29:00 +0100 Message-ID: <87v7x38i03.fsf@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On 2024-10-30 at 15:36 +01, Krzysztof Kozlowski wrote: > On 30/10/2024 15:34, Krzysztof Kozlowski wrote: > > On 30/10/2024 13:02, Steffen Trumtrar wrote: > >> From: Teh Wen Ping > >> > >> Add Intel SoCFPGA Agilex5 clock definition. > > > > Where is the binding? I see only clock IDs. Your commit msg should > > explain such unusual cases. > > > > Eh, I just found it in the kernel. Please, do not work on some ancient > kernels. You are duplicating existing code, already accepted or reviewed. Meh, yes, you are right. clock != clk... So only the clock driver itself is missing and I will remove the binding patch. Even better. Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |