public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, David Gow <davidgow@google.com>,
	linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com
Subject: Re: [PATCH 3/3] debugobjects: Use hlist_cut_number() to optimize performance and improve readability
Date: Mon, 07 Oct 2024 14:22:10 +0200	[thread overview]
Message-ID: <87v7y4t85p.ffs@tglx> (raw)
In-Reply-To: <878qvya7u6.ffs@tglx>

On Wed, Sep 11 2024 at 10:54, Thomas Gleixner wrote:
> On Wed, Sep 11 2024 at 15:44, Leizhen wrote:
>> 2. Member tot_cnt of struct global_pool can be deleted. We can get it
>>    simply and quickly through (slot_idx * ODEBUG_BATCH_SIZE). Avoid
>>    redundant maintenance.
>
> Agreed.
>
>> 3. debug_objects_pool_min_level also needs to be adjusted accordingly,
>>    the number of batches of the min level.
>
> Sure. There are certainly more problems with that code. As I said, it's
> untested and way to big to be reviewed. I'll split it up into more
> manageable bits and pieces.

I finally found some time and ended up doing it differently. I'll send
out the patches later today.

Thanks,

        tglx

      parent reply	other threads:[~2024-10-07 12:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-04 13:41 [PATCH 0/3] debugobjects: Add hlist_cut_number() and use it to optimize code Zhen Lei
2024-09-04 13:41 ` [PATCH 1/3] list: add hlist_cut_number() Zhen Lei
2024-09-04 13:41 ` [PATCH 2/3] list: test: Add a test for hlist_cut_number() Zhen Lei
2024-09-07  6:49   ` David Gow
2024-09-04 13:41 ` [PATCH 3/3] debugobjects: Use hlist_cut_number() to optimize performance and improve readability Zhen Lei
2024-09-09 18:41   ` Thomas Gleixner
2024-09-10  4:00     ` Leizhen (ThunderTown)
2024-09-10 11:44       ` Thomas Gleixner
2024-09-11  7:44         ` Leizhen (ThunderTown)
2024-09-11  8:54           ` Thomas Gleixner
2024-09-11  9:38             ` Leizhen (ThunderTown)
2024-10-07 12:22             ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7y4t85p.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=davidgow@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox