Re: [PATCH v3 4/4] arm64: dts: qcom: sc8280xp-x13s: keep less regulators always-on

Johan Hovold
2024-09-05T14:04:29Z

On Thu, Sep 05, 2024 at 02:20:22PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Remove the regulator-always-on property from the ones that used to be
> implicitly needed by the on-board WCN6855 now that its PMU is modeled in
> device-tree.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index 88b31550f9df..1a9dac16c952 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -479,7 +479,6 @@ vreg_s10b: smps10 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> - regulator-always-on;
> };

What makes you think s10b is only used by wcn6855?

You clearly did not check the schematics so make sure you verify the
rest as well before resending.

And if any of these are valid, I think this should be part of the
previous patch.

Johan