Re: [PATCH v3 1/4] arm64: dts: qcom: sc8280xp-crd: model the PMU of the on-board wcn6855

Bartosz Golaszewski
2024-09-05T12:53:57Z

On Thu, Sep 5, 2024 at 2:50 PM Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
>
> On Thu, Sep 05, 2024 at 02:20:19PM GMT, Bartosz Golaszewski wrote:
> > From: Konrad Dybcio <konradybcio@kernel.org>
> >
> > Add nodes for the WCN6855 PMU, the WLAN module and relevant regulators
> > and pin functions to fully describe how the wifi is actually wired on
> > this platform.
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Signed-off-by: Konrad Dybcio <konradybcio@kernel.org>
> > [Bartosz:
> > - write the commit message,
> > - rebase Konrad's commit,
> > - fix one of the supplies' name]
> > Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 108 ++++++++++++++++++++++
> > 1 file changed, 108 insertions(+)
> >
> > @@ -583,6 +668,23 @@ &pcie4_phy {
> > status = "okay";
> > };
> >
> > +&pcie4_port0 {
> > + wifi@0 {
> > + compatible = "pci17cb,1103";
> > + reg = <0x10000 0x0 0x0 0x0 0x0>;
> > +
> > + vddrfacmn-supply = <&vreg_pmu_rfa_cmn_0p8>;
> > + vddaon-supply = <&vreg_pmu_aon_0p8>;
> > + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> > + vddwlmx-supply = <&vreg_pmu_wlmx_0p8>;
> > + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
> > + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
> > + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> > + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> > + vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
>
> As you are going to post another revision, please also add
>
> qcom,ath11k-calibration-variant
>

I had it in earlier revisions. The only one we could add here would be
the one from X13s as QCom has not yet released the data for the CRD.
Johan and Konrad were against adding this here if it doesn't refer to
the correct one so I dropped it.

Bart

> > + };
> > +};
> > +
> > &pmc8280c_lpg {
> > status = "okay";
> > };
>
> --
> With best wishes
> Dmitry