Re: [PATCH] staging: media: atomisp: Add parentheses around macro definitions

Greg Kroah-Hartman
2024-07-30T06:38:55Z

On Tue, Jul 30, 2024 at 03:23:45PM +0900, Sean Whitton wrote:
> Fix checkpatch error
> "ERROR: Macros with complex values should be enclosed in parentheses"
> at hive_isp_css_include/sp.h:41, hive_isp_css_include/sp.h:42.
>
> Signed-off-by: Sean Whitton <spwhitton@spwhitton.name>
> ---
> drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> This is my first Linux kernel patch, from Helen Koike's DebConf24 workshop.
> Thanks!
>
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h
> index a7d00c7bb8bc..128109afe842 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/sp.h
> @@ -38,8 +38,8 @@
> #define STORAGE_CLASS_SP_C
> #include "sp_public.h"
> #else /* __INLINE_SP__ */
> -#define STORAGE_CLASS_SP_H static inline
> -#define STORAGE_CLASS_SP_C static inline
> +#define STORAGE_CLASS_SP_H (static inline)
> +#define STORAGE_CLASS_SP_C (static inline)

This isn't a "complex values", and really should just be removed
entirely and use the correct "static inline" properly.

thanks,

greg k-h