Re: [PATCH] staging: media: atomisp: Add parentheses around macro definitions

Sean Whitton
2024-08-03T05:34:09Z

Hello,

On Fri 02 Aug 2024 at 11:28pm -05, Dan Carpenter wrote:

> *You* need to figure out what the proper thing is. Not us. That's the
> difficult part of writing a patch. Once you know what the correct thing
> is, then the rest is just typing.
>
> That business of defining STORAGE_CLASS_SP_C is weird. Figure out the
> authors intention and find a better way to do it.
>
> Figure out why your code compiled as well because putting parentheses
> around (static inline) is a syntax error.

I asked follow-up questions because it seems like at least partially a
matter of style to say that the business of defining STORAGE_CLASS_SP_C
is weird. Maybe there is a better approach than what is currently done,
but maybe there isn't. Maybe the checkpatch warning should just be
suppressed (if that's something that can be done). I would be grateful
for some additional pointers.

--
Sean Whitton