From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76AACC61D85 for ; Tue, 21 Nov 2023 16:13:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbjKUQNl (ORCPT ); Tue, 21 Nov 2023 11:13:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjKUQNk (ORCPT ); Tue, 21 Nov 2023 11:13:40 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9360192; Tue, 21 Nov 2023 08:13:36 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7577B218F2; Tue, 21 Nov 2023 16:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1700583215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCkj0KpxevVvJ98XKlce4SLP6YBN2XcCVZPkTge4FWo=; b=BYJ2pZ6ixbRu5iK4rUeak472a+b1qznqNPZdaKPL8Yxq9Yd38+0123gu0JxZkQqFFYipX/ UQI4CHGR2UwN0zbuiFPEyZdtoCvP0PP12zJWbBOkmHBQ9RlQx9Xy2/ZGzCelsIRzOx13vD vbh1sy5E5wsjg/2I8fGfxFnBTkxe/kA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1700583215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vCkj0KpxevVvJ98XKlce4SLP6YBN2XcCVZPkTge4FWo=; b=XuTF1gYB0r91E0r9oS5olHMxQKtFdKGz111BrWM1roDiUu94T+B15u9FZi3jj+h4NSVk9q RpJtEWbBBGBiatBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C4C9138E3; Tue, 21 Nov 2023 16:13:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SELvBS/XXGXEEAAAMHmgww (envelope-from ); Tue, 21 Nov 2023 16:13:35 +0000 Date: Tue, 21 Nov 2023 17:13:34 +0100 Message-ID: <87v89v9j9t.wl-tiwai@suse.de> From: Takashi Iwai To: Lee Jones Cc: Pavel Machek , Takashi Iwai , Jean-Jacques Hiblot , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Johannes =?ISO-8859-1?Q?Pen=DFel?= , Jeremy Soller , Hans de Goede , Bagas Sanjaya Subject: Re: [PATCH] Revert "leds: class: Store the color index in struct led_classdev" In-Reply-To: <170057941222.880794.5199112193553712244.b4-ty@kernel.org> References: <20231121142629.27083-1-tiwai@suse.de> <170057941222.880794.5199112193553712244.b4-ty@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-4.45 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; BAYES_HAM(-1.65)[92.79%]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCPT_COUNT_SEVEN(0.00)[10]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_CC(0.00)[ucw.cz,suse.de,traphandler.com,vger.kernel.org,gmail.com,system76.com,redhat.com]; RCVD_COUNT_TWO(0.00)[2]; SUSPICIOUS_RECIPS(1.50)[] Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Nov 2023 16:10:12 +0100, Lee Jones wrote: > > On Tue, 21 Nov 2023 15:26:29 +0100, Takashi Iwai wrote: > > This reverts commit c7d80059b086c4986cd994a1973ec7a5d75f8eea. > > > > The commit caused regressions to a few drivers (such as Logitech > > keyboard or System76 ACPI) that already had "color" leds sysfs entry; > > now they conflict with the commonly created sysfs of led class. > > > > For addressing the regression, we revert the commit, so that the > > conflicting "color" sysfs entry is removed. > > > > [...] > > Applied, thanks! > > [1/1] Revert "leds: class: Store the color index in struct led_classdev" > commit: 17e1ad377bb1d39260e0594ee284d8e03f64fdfb It turned out that drivers/leds/rgb/leds-group-multicolor.c initializes the cdev->color, and this revert breaks it. So please scratch my previous revert patch. I'm going to submit a partial revert instead. thanks, Takashi