From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8955BC83F2C for ; Sun, 3 Sep 2023 16:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244881AbjICQdA (ORCPT ); Sun, 3 Sep 2023 12:33:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237525AbjICQc7 (ORCPT ); Sun, 3 Sep 2023 12:32:59 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 453D6106 for ; Sun, 3 Sep 2023 09:32:56 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9F786215EF; Sun, 3 Sep 2023 16:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693758772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qc+cXtlFIHY98BK4i6pthqR7Wa7NW4bm9VGwSkDgbyY=; b=N9Q7PRU1ZFbG6p3fWLT84hgUKsTRnJ8MuEX+SX6cgGuD7WZ+aBuQvvpIE4kD5ZA7BiWAL6 LkAk6HIw2Ih/geeWZ89rfoWfhkgrDg+VoMSHrSBdLnYuL5LZeONKslFwF1O2uWIuJnZFlC xgdjJ40lTS1alnIpP4UF5Eth6DIyVg0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693758772; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qc+cXtlFIHY98BK4i6pthqR7Wa7NW4bm9VGwSkDgbyY=; b=xQfye9VjrI8LkhRR/DbCLgd0aDvMw8863hZlSuaPHhHYyK5qmhZfoVjr9D3Orbgw8icGWS VGPuENc+IQpYwiAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 34AA513583; Sun, 3 Sep 2023 16:32:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XbrNCzS19GT8HgAAMHmgww (envelope-from ); Sun, 03 Sep 2023 16:32:52 +0000 Date: Sun, 03 Sep 2023 18:32:51 +0200 Message-ID: <87v8crkyj0.wl-tiwai@suse.de> From: Takashi Iwai To: Shenghao Ding Cc: , , , , , , <13916275206@139.com>, , , , , , , , , , Subject: Re: [PATCH v1 1/2] ALSA: hda/tas2781: Update tas2781 HDA driver In-Reply-To: <20230903143759.92-1-shenghao-ding@ti.com> References: <20230903143759.92-1-shenghao-ding@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 03 Sep 2023 16:37:57 +0200, Shenghao Ding wrote: > > Support ACPI_ID both TXNW2781 and TIAS2781, and revert structure > cs35l41_dev_name. Could you explain why you need to revert? That's the important piece. And, what is found in below... > --- > Changes in v1: > - Redefine tas2781_generic_fixup, remove hid param > - TIAS2781 has been used by our customers, see following dstd.dsl. We > have discussed this with them, they requested TIAS2781 must be > supported for the laptops already released to market, their new > laptops will switch to TXNW2781 > Name (_HID, "TIAS2781") // _HID: Hardware ID > Name (_UID, Zero) // _UID: Unique ID > Method (_SUB, 0, NotSerialized) // _SUB: Subsystem ID > { > If ((SPID == Zero)) > { > Return ("17AA3886") > } > > If ((SPID == One)) > { > Return ("17AA3884") > } ... such information should be mentioned in the changelog. It can be even commented in the code. Last but not least, if you do two things, split to two patches -- unless the rename is closely tied with the support of both IDs. thanks, Takashi