From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B789AC0015E for ; Sat, 12 Aug 2023 15:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230251AbjHLPBM (ORCPT ); Sat, 12 Aug 2023 11:01:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjHLPBK (ORCPT ); Sat, 12 Aug 2023 11:01:10 -0400 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0454E10FB for ; Sat, 12 Aug 2023 08:01:12 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id C7D7F1C0002; Sat, 12 Aug 2023 15:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1691852471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Alzx0G/XPXpFyVa7O/4kvWcI5FZUIwHqNqauLfR57Lk=; b=d5UegVnwQCxkeqnhM19cX1CA2NdPjbFqAp9XfSh6kdknk/PpLZ7+GTGeorsXHP+Pp9YBd7 Tt+Y/VNZ7fQcMi9bxO5/sJqX0YMlTYJ/B/BJTowF7kopZHdC+HrZuG9oN2YD7eJ5zXR4rd 3Mqr/Hi9DCe2E8GKHI4rGA9AQUuc5h/wvxTEnZBcbvq8k+zMnoNUQvCexfRkrnBJvgDiN3 +W2sXsFQWxg/uFdhExGK3DS6l/rLvLg30iok1dMRlzQN0pktoLw9FxzBOfIYoX6zwAzu8y QCbL9Z6uzXXl8pp4nXTBDh71HzUx+QKvC7N3Tq055TorH9Pa2vUY/DVmlFaJKA== From: Gregory CLEMENT To: Rob Herring , Andrew Lunn , Sebastian Hesselbarth , Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: mvebu: Explicitly include correct DT includes In-Reply-To: <20230717225456.3212019-1-robh@kernel.org> References: <20230717225456.3212019-1-robh@kernel.org> Date: Sat, 12 Aug 2023 17:01:09 +0200 Message-ID: <87v8dktidm.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: gregory.clement@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rob Herring writes: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring Applied on mvebu/arm Thanks, Gregory > --- > arch/arm/mach-mvebu/kirkwood.c | 1 + > arch/arm/mach-mvebu/pmsu.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c > index 8ff34753e760..73b2a86d6489 100644 > --- a/arch/arm/mach-mvebu/kirkwood.c > +++ b/arch/arm/mach-mvebu/kirkwood.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c > index 6f366d8c4231..79c5171f06ec 100644 > --- a/arch/arm/mach-mvebu/pmsu.c > +++ b/arch/arm/mach-mvebu/pmsu.c > @@ -23,8 +23,8 @@ > #include > #include > #include > +#include > #include > -#include > #include > #include > #include > -- > 2.40.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com