public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Osama Muhammad <osmtendev@gmail.com>
Cc: nbd@nbd.name, ryder.lee@mediatek.com, lorenzo@kernel.org,
	shayne.chen@mediatek.com, davem@davemloft.net,
	linux-wireless@vger.kernel.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs.c: Fix error checking for debugfs_create_dir
Date: Tue, 30 May 2023 13:29:37 +0300	[thread overview]
Message-ID: <87v8gajeni.fsf@kernel.org> (raw)
In-Reply-To: <20230524160352.19704-1-osmtendev@gmail.com> (Osama Muhammad's message of "Wed, 24 May 2023 21:03:52 +0500")

Osama Muhammad <osmtendev@gmail.com> writes:

> This patch fixes the error checking in debugfs.c in
> debugfs_create_dir. The correct way to check if an error occurred
> is using 'IS_ERR' inline function.
>
> Signed-off-by: Osama Muhammad <osmtendev@gmail.com>

The title is wrong, please see the wiki page below how to create titles.

Also no need to say "This patch fixes..", saying "Fix..." is enough.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2023-05-30 10:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 16:03 [PATCH] debugfs.c: Fix error checking for debugfs_create_dir Osama Muhammad
2023-05-24 15:55 ` [PATCH] nfcsim.c: " Osama Muhammad
2023-05-25  8:12   ` Simon Horman
2023-05-30 10:29 ` Kalle Valo [this message]
2023-05-30 11:02   ` [PATCH] debugfs.c: " Osama Muhammad
2023-05-30 11:19     ` Osama Muhammad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8gajeni.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=osmtendev@gmail.com \
    --cc=ryder.lee@mediatek.com \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox