From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32F3C77B7F for ; Wed, 26 Apr 2023 10:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239943AbjDZKsN (ORCPT ); Wed, 26 Apr 2023 06:48:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240224AbjDZKrw (ORCPT ); Wed, 26 Apr 2023 06:47:52 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24294E67 for ; Wed, 26 Apr 2023 03:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682506022; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q7eSG1klkAdyLEaNU1h7MS+MxhJ0DOqewp5Z8jQS+rk=; b=F1NAXP23RESFvqE515uSZfCqvlrPgo6WHQ+LKn1Vx/rnL7gR9IbT3buydMNvkKdBLW/qkN QrT/X5PpP0KK5j+IdmKII2hWNa6BhdlSgQAIjnv/e41DJjJrMFbfrbcWd8Sirrv2uggk4P K0ViDOY0f3sTZ1psLVSnbVEebn8CllE= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-xQsOUgZnOo6XqIu2hmEDsw-1; Wed, 26 Apr 2023 06:47:01 -0400 X-MC-Unique: xQsOUgZnOo6XqIu2hmEDsw-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-94a34e35f57so620196266b.3 for ; Wed, 26 Apr 2023 03:47:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682506020; x=1685098020; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q7eSG1klkAdyLEaNU1h7MS+MxhJ0DOqewp5Z8jQS+rk=; b=lDXASlrNM0+Tt9WbYA5FtvTPe5Sydwb30H0iM77lEP2MnmGqX1PteLAscvTOREVABm Fh2QKYGK7tW1YQK3bEDb8yLoLx5OuyVlZ+3nyL5gz3Tq/nhYFt2qLhiNGtGJ1ksySUL+ kE+qyKlDSrLtfW2SYeNW1U42PPFv3CtyTpG6LaWVsC4MVf+vaNH7oqH9WQFb3ccWfrc/ 6PRCMsjUHYj8ezgIBxAtkRUdACWMcOMluugUY4dw4706irRjiGY+fWfGZ4RNQhWc1tmj ODEYvOQNQAJXrbgkIDE+7cn4PXK08ARxrxCA3lkFyiILr93Cg71RtS+5Ly3rHjEqhM+f ld9w== X-Gm-Message-State: AAQBX9dgVdeIzvePWuLCZNbrv2Z10/YT+eXMguj67KRj7r2FWcnb5ek4 Qe57/m/8HoJZJ2HOZyPB/lyM8ZdIKjP64UtO51sboFIJzEWbnrSeku4Dfq+kRYNcivoGWqhEs1R WZBWmaU8kc56RFF2u7UtjaMSG X-Received: by 2002:a17:906:a84c:b0:947:c8d5:fb2a with SMTP id dx12-20020a170906a84c00b00947c8d5fb2amr17287739ejb.48.1682506019823; Wed, 26 Apr 2023 03:46:59 -0700 (PDT) X-Google-Smtp-Source: AKy350bueCmxCjDSmFglv2TB/hZ+jA43sk3LCYfVFX9cQwRdfdOgUzEC5j8gS5n5MB/sN1wMbcmEvQ== X-Received: by 2002:a17:906:a84c:b0:947:c8d5:fb2a with SMTP id dx12-20020a170906a84c00b00947c8d5fb2amr17287691ejb.48.1682506019416; Wed, 26 Apr 2023 03:46:59 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id lb16-20020a170907785000b0094ee700d8e4sm7946826ejc.44.2023.04.26.03.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 03:46:58 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 44A81AAA41C; Wed, 26 Apr 2023 12:46:58 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kal Conley , Magnus Karlsson , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= , Maciej Fijalkowski , Jonathan Lemon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend Cc: Kal Conley , Bagas Sanjaya , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v6 2/4] xsk: Support UMEM chunk_size > PAGE_SIZE In-Reply-To: <20230412162114.19389-3-kal.conley@dectris.com> References: <20230412162114.19389-1-kal.conley@dectris.com> <20230412162114.19389-3-kal.conley@dectris.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 26 Apr 2023 12:46:58 +0200 Message-ID: <87v8hij4yl.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kal Conley writes: > Add core AF_XDP support for chunk sizes larger than PAGE_SIZE. This > enables sending/receiving jumbo ethernet frames up to the theoretical > maximum of 64 KiB. For chunk sizes > PAGE_SIZE, the UMEM is required > to consist of HugeTLB VMAs (and be hugepage aligned). Initially, only > SKB mode is usable pending future driver work. So I still really don't understand why this is useful without the driver support, and I think it's premature to merge it before that is present. It also seems you didn't address any of the issues we discussed back on v3, but instead just reposted (and didn't even Cc me, so I missed that until now). So, FWIW, consider this my: Nacked-by: Toke H=C3=B8iland-J=C3=B8rgensen