public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Stefan Binding <sbinding@opensource.cirrus.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
	<patches@opensource.cirrus.com>,
	Vitaly Rodionov <vitalyr@opensource.cirrus.com>
Subject: Re: [PATCH v1 1/3] ALSA: hda/cs35l41: Fix error condition check
Date: Fri, 10 Feb 2023 10:10:40 +0100	[thread overview]
Message-ID: <87v8k9j373.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230209160403.838326-2-sbinding@opensource.cirrus.com>

On Thu, 09 Feb 2023 17:04:01 +0100,
Stefan Binding wrote:
> 
> From: Vitaly Rodionov <vitalyr@opensource.cirrus.com>
> 
> Function hda_cs_dsp_write_ctl() returns 3 possible values:
> 0 - no change, 1 - value has changed and -1 - error, so value 1
> is not an error.
> 
> Signed-off-by: Vitaly Rodionov <vitalyr@opensource.cirrus.com>

When you submit a patch, you must add your Signed-off-by line.

Also, this looks like no new bug, so it's worth to add Fixes tag, if
any?  (Not only about this patch but others, too.)

Last but not least, please make the subject prefix consistent over the
patch series.


thanks,

Takashi

  reply	other threads:[~2023-02-10  9:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-09 16:04 [PATCH v1 0/3] Various Fixes/Improvements for CS35L41 HDA Stefan Binding
2023-02-09 16:04 ` [PATCH v1 1/3] ALSA: hda/cs35l41: Fix error condition check Stefan Binding
2023-02-10  9:10   ` Takashi Iwai [this message]
2023-02-09 16:04 ` [PATCH v1 2/3] ALSA: hda: cs35l41: Ensure firmware/tuning pairs are always loaded Stefan Binding
2023-02-09 16:04 ` [PATCH v1 3/3] ALSA: hda: cs35l41: Enable Amp High Pass Filter Stefan Binding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8k9j373.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=sbinding@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    --cc=vitalyr@opensource.cirrus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox