From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886AAC54EBE for ; Thu, 12 Jan 2023 19:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230311AbjALTsV (ORCPT ); Thu, 12 Jan 2023 14:48:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232870AbjALTr1 (ORCPT ); Thu, 12 Jan 2023 14:47:27 -0500 X-Greylist: delayed 301 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 12 Jan 2023 11:43:26 PST Received: from mail.tkos.co.il (golan.tkos.co.il [84.110.109.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18FD6F1F; Thu, 12 Jan 2023 11:43:26 -0800 (PST) Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.tkos.co.il (Postfix) with ESMTPS id 7AC07440319; Thu, 12 Jan 2023 21:27:39 +0200 (IST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1673551659; bh=vS60k0tj2u3HznO7yKB7DChKrzNTg3akDjVjvbv3vuk=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=TUl8PMGUNUxB8+l+k2S3hmtX10rrsh5tMMfu/21WnMrXVGKnJYmVODXOJ6rQN6aCV GknJ0ELuEmIa1HdsS5aG+eTtC21AG6OHPdV2Zf83W0Ltg4z4uJoNjcGeDDraAPihAu PjPeAvvq7hDGLLMhxg+iPokOd2S0JQw0u4hnaxxQrlfYTzHPeIIMisrKBcwROEyGmi S8mlRrpHeJ0fiUW0dx09hBe7qvdreGg2UuPsqK7l47BoAb0U+oRGkdhpze+Nt4/tnX YYuQQZE4faHIlU9nZ13LRcF/XRV3HHyT/Isn4GnXB10INMO9MWIJc8xeJv1dvCIHFe 7ub0pap/FaHGA== References: <20230112184823.80349-1-andriy.shevchenko@linux.intel.com> <20230112184823.80349-2-andriy.shevchenko@linux.intel.com> User-agent: mu4e 1.8.10; emacs 28.2 From: Baruch Siach To: Andy Shevchenko Cc: Linus Walleij , Jianlong Huang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 2/2] pinctrl: digicolor: Use proper headers and drop OF dependency Date: Thu, 12 Jan 2023 21:30:46 +0200 In-reply-to: <20230112184823.80349-2-andriy.shevchenko@linux.intel.com> Message-ID: <87v8lbpn24.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andy, On Thu, Jan 12 2023, Andy Shevchenko wrote: > The driver doesn't depend on the OF to be complied. Hence > the proper header to use is mod_devicetable.h. Replace of*.h with > the above mentioned and drop redundant dependency. > > Signed-off-by: Andy Shevchenko Acked-by: Baruch Siach baruch > --- > drivers/pinctrl/Kconfig | 2 +- > drivers/pinctrl/pinctrl-digicolor.c | 9 +++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index 476f3cbbdce0..1e44708201ad 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -170,7 +170,7 @@ config PINCTRL_DA9062 > > config PINCTRL_DIGICOLOR > bool > - depends on OF && (ARCH_DIGICOLOR || COMPILE_TEST) > + depends on ARCH_DIGICOLOR || COMPILE_TEST > select PINMUX > select GENERIC_PINCONF > > diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c > index 05213261b8a4..a0423172bdd6 100644 > --- a/drivers/pinctrl/pinctrl-digicolor.c > +++ b/drivers/pinctrl/pinctrl-digicolor.c > @@ -11,18 +11,19 @@ > * - Pin pad configuration (pull up/down, strength) > */ > > +#include > #include > -#include > -#include > -#include > #include > -#include > +#include > +#include > #include > + > #include > #include > #include > #include > #include > + > #include "pinctrl-utils.h" > > #define DRIVER_NAME "pinctrl-digicolor" -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -