From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A051C0502A for ; Sat, 27 Aug 2022 15:19:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233452AbiH0PS7 (ORCPT ); Sat, 27 Aug 2022 11:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbiH0PS5 (ORCPT ); Sat, 27 Aug 2022 11:18:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3C503FA08 for ; Sat, 27 Aug 2022 08:18:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4026360DD3 for ; Sat, 27 Aug 2022 15:18:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A22CEC433D6; Sat, 27 Aug 2022 15:18:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661613534; bh=3OskzQo5R7SlMm6IC8iuLVq2M7pHJLiJLxaUbpjauSg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hVFdy7tY+/JWR7ntiBxwTaNk5IqHnetp3O/gen8bIZV7e3OtIryikyl4cpUerSPIf 2JWnOlGyV4LLidV3Qr2bpn3c5bsgM97p6JShilqDJkEoq/84wrgPCJ4pSMX6faXy25 Dmg+4ZnHgHZIY8KOVtPrN5m691KNnCP6kc2JIppWkcQ/imf2WbiVpIipxD3Qb0vfRj q/QueDaLwBiFfGFRKgwYJIKtBehRl2EH9MDr/NJcFMCoR9H3SXULfAtAwcVlSNFof2 R4S2WFxEL/qRmyBubdB14EWyFfjJWQraqKyZUydNEZz4i6Wbz371AEdpig8SccTIx8 LscuzElxS3aOw== Received: from [12.191.126.171] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oRxaG-006B9H-0j; Sat, 27 Aug 2022 16:18:52 +0100 Date: Sat, 27 Aug 2022 16:18:48 +0100 Message-ID: <87v8qdr9yf.wl-maz@kernel.org> From: Marc Zyngier To: Xu Qiang Cc: , , , , , , , , Subject: Re: [PATCH -next 1/3] genirq/affinity: replace managed with is_managed in irq_affinity_desc In-Reply-To: <20220827011351.9185-1-xuqiang36@huawei.com> References: <20220827011351.9185-1-xuqiang36@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 12.191.126.171 X-SA-Exim-Rcpt-To: xuqiang36@huawei.com, tglx@linutronix.de, frederic@kernel.org, peterz@infradead.org, nitesh@redhat.com, bigeasy@linutronix.de, douliyangs@gmail.com, linux-kernel@vger.kernel.org, guohanjun@huawei.com, weiyongjun1@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Aug 2022 02:13:49 +0100, Xu Qiang wrote: >=20 > This submission is based on the following two considerations: >=20 > 1. The definition of is_managed field is misleading to assume > that it only uses 1 bit of memory, which is not the case; You realise that a bitfield is not about the memory used, but the number of significant bits, right? The memory it uses is the compiler's business. > 2. from the actual use of is_managed, it should be a Boolean type; Why? What is wrong with the existing bitfield? Why renaming it? > > Fixes: c410abbbacb9 (=E2=80=9Cgenirq/affinity: Add is_managed to struct i= rq_affinity_desc=E2=80=9D) I don't see any fix here, only some seemingly pointless bike-shedding. If you have identified an actual issue, please spell it out for me, because I cannot see it. Thanks, M. --=20 Without deviation from the norm, progress is not possible.