From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B2B5C43334 for ; Thu, 7 Jul 2022 08:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235162AbiGGI1G (ORCPT ); Thu, 7 Jul 2022 04:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234945AbiGGI1D (ORCPT ); Thu, 7 Jul 2022 04:27:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 02BCB14D21 for ; Thu, 7 Jul 2022 01:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657182421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hyQUq78HZYV0U5amrGZK5Au62aqwa+QCBY5NRkOA5vM=; b=Za1c3dchr9VjWfrfMwzbmap30VjOuSjq8jpKqxO9feLQkidfcNtGkfSjYRLrw51CdMSVyZ l44mgb8yrPR6nw82yuQHX1wVC+3EzdKglDHla7aTQdVHH5nWJLpiQjnkSR/zQ2waM5ZAk4 fvM/tVl90P8vzI3fQNWZwyxjYvzfwjo= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-hp2mYy4NONukDtTQ4jzcxA-1; Thu, 07 Jul 2022 04:26:59 -0400 X-MC-Unique: hp2mYy4NONukDtTQ4jzcxA-1 Received: by mail-ej1-f72.google.com with SMTP id sg40-20020a170907a42800b00722faf0aacbso4466460ejc.3 for ; Thu, 07 Jul 2022 01:26:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=hyQUq78HZYV0U5amrGZK5Au62aqwa+QCBY5NRkOA5vM=; b=lVmGSf5uJ6xKg19jmxNkSz2t7HGXtgOQ7GGw1W/A9NOgvn5FIIbOqoLE7ATddkSBAD v7VMKw7fItHoHLrXijuqb27yTQiJ037pJmXeY+vWer0++CUgeNovFmDohIyguz34HaNG aoYFbPArsKw7vv/XUv6B30X9/zGFHalxkNAm+EjfIq7YGxn+w2KcQ6x+yAGyBNAqwpJh nQOD8InMoywZrrxruRd07pJAWB5K7DphTa4j0nFCHyT33or2SgjXVr6VOAWbj1ZM7NYA q8OCvmjjyyAUWL35RN/ypVsTQnDbHXV0inbS0ahYhV8BMfFKB5USTKwNkrBXMeAZYhik rksQ== X-Gm-Message-State: AJIora8DRN+DZObUkEFGbWLJ6TJsJnUmYq4NYTywCVftKgkCVb+DsG/E HL34rB++Na2V2nIiI9Ua38Ac8uoTdcXmm1viz9CeZZP5XbQsbGuhxOGwlghI1hzW6QdRnI9ZH7K IMuOuTH5ujZ+thpLgcl+C/EQm X-Received: by 2002:a05:6402:c0b:b0:43a:25ff:ff08 with SMTP id co11-20020a0564020c0b00b0043a25ffff08mr32234926edb.148.1657182418713; Thu, 07 Jul 2022 01:26:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uvaDV9BbuUE121Sm+1DSqPLexh4d8iG52AgkDo+XRYCQ8whzlmbqjuBkwqDmHZx8J/VKLzYA== X-Received: by 2002:a05:6402:c0b:b0:43a:25ff:ff08 with SMTP id co11-20020a0564020c0b00b0043a25ffff08mr32234901edb.148.1657182418538; Thu, 07 Jul 2022 01:26:58 -0700 (PDT) Received: from fedora (nat-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id eo7-20020a056402530700b0043a78236cd2sm5689000edb.89.2022.07.07.01.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 01:26:58 -0700 (PDT) From: Vitaly Kuznetsov To: Wang Guangju Cc: linux-kernel@vger.kernel.org, wangguangju@baidu.com, seanjc@google.com, pbonzini@redhat.com, jmattson@google.com, wanpengli@tencent.com, bp@alien8.de, joro@8bytes.org, suravee.suthikulpanit@amd.com, hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: x86: Add EOI exit bitmap handlers for Hyper-V SynIC vectors In-Reply-To: <20220705083732.168-1-wangguangju@baidu.com> References: <20220705083732.168-1-wangguangju@baidu.com> Date: Thu, 07 Jul 2022 10:26:56 +0200 Message-ID: <87v8s9qqen.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wang Guangju writes: > From: wangguangju > > Hyper-V SynIC vectors were added into EOI exit bitmap in func > synic_set_sint().But when the Windows VM VMEXIT due to > EXIT_REASON_EOI_INDUCED, there are no EOI exit bitmap handlers > for Hyper-V SynIC vectors. My take: "When EOI virtualization is performed on VMX, kvm_apic_set_eoi_accelerated() is called upon EXIT_REASON_EOI_INDUCED but unlike its non-accelerated apic_set_eoi() sibling, Hyper-V SINT vectors are left unhandled. " > > This patch fix it. > > Change-Id: I2404ebf7bda60326be3f6786e0e34e63aa81bbd4 In case this is not something publicly available it doesn't belong to kernel changelog as it doesn't bring any value. > Signed-off-by: wangguangju > --- > arch/x86/kvm/lapic.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c > index 0e68b4c..59096f8 100644 > --- a/arch/x86/kvm/lapic.c > +++ b/arch/x86/kvm/lapic.c > @@ -1303,6 +1303,10 @@ void kvm_apic_set_eoi_accelerated(struct kvm_vcpu *vcpu, int vector) > > trace_kvm_eoi(apic, vector); > > + if (to_hv_vcpu(apic->vcpu) && > + test_bit(vector, to_hv_synic(apic->vcpu)->vec_bitmap)) > + kvm_hv_synic_send_eoi(apic->vcpu, vector); > + > kvm_ioapic_send_eoi(apic, vector); > kvm_make_request(KVM_REQ_EVENT, apic->vcpu); This whole part: if (to_hv_vcpu(apic->vcpu) && test_bit(vector, to_hv_synic(apic->vcpu)->vec_bitmap)) kvm_hv_synic_send_eoi(apic->vcpu, vector); kvm_ioapic_send_eoi(apic, vector); kvm_make_request(KVM_REQ_EVENT, apic->vcpu); could be split into an inline function, something like (completely untested): diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c index 6ff17d5a2ae3..9d19c7c738c0 100644 --- a/arch/x86/kvm/lapic.c +++ b/arch/x86/kvm/lapic.c @@ -1269,6 +1269,16 @@ static void kvm_ioapic_send_eoi(struct kvm_lapic *apic, int vector) kvm_ioapic_update_eoi(apic->vcpu, vector, trigger_mode); } +static inline void apic_set_eoi_vector(struct kvm_lapic *apic, int vector) +{ + if (to_hv_vcpu(apic->vcpu) && + test_bit(vector, to_hv_synic(apic->vcpu)->vec_bitmap)) + kvm_hv_synic_send_eoi(apic->vcpu, vector); + + kvm_ioapic_send_eoi(apic, vector); + kvm_make_request(KVM_REQ_EVENT, apic->vcpu); +} + static int apic_set_eoi(struct kvm_lapic *apic) { int vector = apic_find_highest_isr(apic); @@ -1285,12 +1295,8 @@ static int apic_set_eoi(struct kvm_lapic *apic) apic_clear_isr(vector, apic); apic_update_ppr(apic); - if (to_hv_vcpu(apic->vcpu) && - test_bit(vector, to_hv_synic(apic->vcpu)->vec_bitmap)) - kvm_hv_synic_send_eoi(apic->vcpu, vector); + apic_set_eoi_vector(apic, vector); - kvm_ioapic_send_eoi(apic, vector); - kvm_make_request(KVM_REQ_EVENT, apic->vcpu); return vector; } @@ -1304,8 +1310,7 @@ void kvm_apic_set_eoi_accelerated(struct kvm_vcpu *vcpu, int vector) trace_kvm_eoi(apic, vector); - kvm_ioapic_send_eoi(apic, vector); - kvm_make_request(KVM_REQ_EVENT, apic->vcpu); + apic_set_eoi_vector(apic, vector); } EXPORT_SYMBOL_GPL(kvm_apic_set_eoi_accelerated); > } -- Vitaly